Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add releaseDate to partner card (#4315)(release) #821

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses bloom-housing#4300

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR completes an outstanding todo to include the releaseDate in the partners messaging seen in the issue description. It also handles the case of releasing and retracting by finding the most recent release date.

How Can This Be Tested/Reviewed?

This can be tested by creating a lottery listing as an admin and releasing that lottery. Then as a partner user see the date and time reflected in the lottery publish card. You can also test retracting and releasing the lottery to see the time updated.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* fix: complete todo

* fix: findLast alternative
@ColinBuyck ColinBuyck added 1 review needed release A PR that is pulling over a commit(s) from core labels Sep 13, 2024
@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Sep 13, 2024
@emilyjablonski emilyjablonski merged commit 9c5b138 into main Sep 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved release A PR that is pulling over a commit(s) from core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants