Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.3 #122

Closed
wants to merge 4 commits into from
Closed

Allow PHP 8.3 #122

wants to merge 4 commits into from

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 3, 2023

No description provided.

Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@fezfez
Copy link
Contributor Author

fezfez commented Nov 3, 2023

Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@froschdesign froschdesign changed the title allow php 8.3 Allow PHP 8.3 Nov 3, 2023
@froschdesign froschdesign added the Enhancement New feature or request label Nov 3, 2023
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
<file src="src/AbstractStaticResourceHandlerFactory.php">
<ArgumentTypeCoercion>
<code>$lastModifiedDirectives</code>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't find a way to suppress this error, if anyone (like @Ocramius :D ) can check this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to baseline this, IMO

@weierophinney
Copy link
Contributor

@fezfez Before I tag laminas-ci-swoole-builder... what versions of swoole and openswoole should I build into the container images?

@fezfez
Copy link
Contributor Author

fezfez commented Nov 6, 2023

@fezfez Before I tag laminas-ci-swoole-builder... what versions of swoole and openswoole should I build into the container images?

I don't know but, if the build as it Is ok, I think it's ok to push

@weierophinney
Copy link
Contributor

weierophinney commented Nov 6, 2023

I don't know but, if the build as it Is ok, I think it's ok to push

That's not how it works. 😄

When I tag, I build Swoole and OpenSwoole for each supported PHP version, package them, and push them up to the release as release assets. Those packages are what the CI uses.

That's why I need to know which versions of Swoole and OpenSwoole to build.

@fezfez
Copy link
Contributor Author

fezfez commented Nov 7, 2023

I don't know but, if the build as it Is ok, I think it's ok to push

That's not how it works. 😄

When I tag, I build Swoole and OpenSwoole for each supported PHP version, package them, and push them up to the release as release assets. Those packages are what the CI uses.

That's why I need to know which versions of Swoole and OpenSwoole to build.

According to remicollet/remirepo#237 the release are not yet available

Edit 1 : see also openswoole/ext-openswoole#336

@fezfez fezfez closed this Nov 7, 2023
@fezfez fezfez reopened this Nov 7, 2023
@weierophinney
Copy link
Contributor

@fezfez

According to remicollet/remirepo#237 the release are not yet available

We build from source. So the question is: are there PHP 8.3-compatible versions of swoole and/or openswoole for me to build?

@fezfez
Copy link
Contributor Author

fezfez commented Nov 7, 2023

@fezfez

According to remicollet/remirepo#237 the release are not yet available

We build from source. So the question is: are there PHP 8.3-compatible versions of swoole and/or openswoole for me to build?

Like I say, if you look at the link there is no compatible version

@weierophinney
Copy link
Contributor

@fezfez It looks like patches exist for each of Swoole and OpenSwoole, but no releases have been made yet. I may be able to accommodate those, but not before next week. As such, this patch is on hold until we can get builds created, which will either be based on the patches that allow each extension to build against 8.3, or after releases are made.

@gsteel
Copy link
Member

gsteel commented Nov 8, 2023

OpenSwoole just released: https://github.com/openswoole/ext-openswoole/releases/tag/v22.1.0

@fezfez
Copy link
Contributor Author

fezfez commented Dec 7, 2023

Swoole have been released https://github.com/swoole/swoole-src/releases/tag/v5.1.1

@Xerkus
Copy link
Member

Xerkus commented Dec 7, 2023

we are aware

@Xerkus
Copy link
Member

Xerkus commented Jan 15, 2024

Picked phpunit fixes for #125
Thank you.

Superseded by #124

@Xerkus Xerkus closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants