Fix Swoole v5 compatibility in hot reloader. Fix unit tests #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
…ck() call in hot reloader Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/swoole-v5-tests
branch
from
7e8bc7d
to
0701fb5
Compare
weierophinney
requested changes
Jan 12, 2024
weierophinney
approved these changes
Jan 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing CI setup to use swoole from ondrej ppa used in our CI container. This is not ideal setup but it will allow to unblock support for PHP 8.3.
Current CI setup is not sufficient as it does not test different versions of swoole and does not test for openswoole. It is a task for another day. Considering swoole and openswoole are set to diverge different kind of approach would need to be taken anyway.
Stricter types in swoole v5 uncovered some deficiencies in unit test mocks. This PR fixes those issues and takes care of updating a few phpunit deprecations.
While rest of the mezzio-swoole is compatible with v5, hot reloader functionality was not due to removal of decorator method
Swoole\Server::tick(). Hot reloader listener is updated to useSwoole\Timer::tick()directly.