Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Mark as Un/reviewed" options to files in code review mode #482

Closed
dan1994 opened this issue Mar 13, 2021 · 2 comments
Closed

Add "Mark as Un/reviewed" options to files in code review mode #482

dan1994 opened this issue Mar 13, 2021 · 2 comments
Assignees
Labels
improvement An improvement to existing functionality
Milestone

Comments

@dan1994
Copy link
Contributor

dan1994 commented Mar 13, 2021

Add two new actions to Commit Details View File Context Menu (

vscode-git-graph/web/main.ts

Lines 2926 to 2958 in ad1ba5c

contextMenu.show([
[
{
title: 'View Diff',
visible: diffPossible,
onClick: () => triggerViewFileDiff(file, fileElem)
},
{
title: 'View File at this Revision',
visible: file.type !== GG.GitFileStatus.Deleted && diffPossible && !isUncommitted,
onClick: () => triggerViewFileAtRevision(file, fileElem)
},
{
title: 'Open File',
visible: file.type !== GG.GitFileStatus.Deleted,
onClick: () => triggerOpenFile(file, fileElem)
}
],
[
{
title: 'Copy Absolute File Path to Clipboard',
visible: true,
onClick: () => triggerCopyFilePath(file, true)
},
{
title: 'Copy Relative File Path to Clipboard',
visible: true,
onClick: () => triggerCopyFilePath(file, false)
}
]
], false, target, <MouseEvent>e, this.isCdvDocked() ? document.body : this.viewElem, () => {
expandedCommit.contextMenuOpen.fileView = -1;
});
):

Mark as Reviewed: Remove the file from the array of files remaining to be reviewed, and unbold it. This would appear when a Code Review is active, and the file isn't reviewed.
Mark as Unreviewed: Add the file back into the array of files remaining to be reviewed, and bold it. This would appear when a Code Review is active, and the file is reviewed.

@dan1994 dan1994 added the improvement An improvement to existing functionality label Mar 13, 2021
@dan1994
Copy link
Contributor Author

dan1994 commented Mar 13, 2021

@mhutchie Please assign to me

dan1994 added a commit to dan1994/vscode-git-graph that referenced this issue Mar 13, 2021
@mhutchie mhutchie assigned dan1994 and unassigned mhutchie Mar 13, 2021
@mhutchie mhutchie added this to the v1.30.0 milestone Mar 13, 2021
mhutchie pushed a commit that referenced this issue Mar 14, 2021
…ile context menu in the Commit Details View when a Code Review is in progress. Squash Merge of @dan1994's PR #483.
@mhutchie
Copy link
Owner

This will be available in v1.30.0.

If you'd like to use it before the next release, you can download v1.30.0-beta.2, and install it following the instructions provided here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants