#482 Add Mark as Un/reviewed options to files in code review mode #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required separating the functionality of changing the last viewed file that was coupled with marking the file as reviewed.
marked as reveiewed but not opened. Added a parameter to the codeReviewFileReviewed message that specifies whether the file was actually opened. This is set to true except when the user uses the Mark as Reviewd option.
This was done both in frontend and backend, with a single message "updateCodeReview". The lastViewedFile is updated in the backend through this message, but updated in the frontend in a seperate function (setLastViewedFile) since in the backend it is considered part of the code review.
Since the backend only changes last viewed file when dealing with code reviewes, it makes sense to do the same in the frontend as well. This also prevents code duplication.
Backend was not updated correctly when file is marked as reviewed.
Fixes dan1994/vscode-git-graph#1
dan1994
changed the title
mhutchie
approved these changes
Mar 14, 2021
There was a problem hiding this comment.
This PR was really well written and thorough! I just made some trivial minor changes before merging this PR:
ExtensionState.updateCodeReviewnow returns a promise, so it can return the result ofExtensionState.setCodeReviews, in addition to the error message you added when the Code Review could not be found.- Updated the unit tests to follow the Setup, Run, Assert pattern used across all unit tests in this repository. This is just a convention to make separate the stages of steps to make them easier to read.
GitGraphView.cdvChangeFileReviewedStatenow accepts afile: GitFileChange, instead of thefilePath: string, just to remove some code duplication when it's being called.- Reworded the unreview action to be "Mark as Not Reviewed" based on some user feedback I got.
- Removed the changes to the trailing whitespace on some unrelated comments, just to remove the noise from this PR. I'll include this in a code clean up commit I was going to do today/tomorrow with some other changes that aren't bound to a specific feature.
|
Hi @dan1994, Thanks again for your contribution to Git Graph, I'm sure many users will value this new capability you've added! I've squash merged this PR in 556e494. Later this afternoon I'll be releasing the next beta release (which will be the first to include this feature). I'll reply and close the feature request #482 when this occurs, and provide instructions for how to manually install it. |
|
Glad to be of help |
dan1994
deleted the
482-Add-Mark-as-Un/reviewed-options-to-files-in-code-review-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #482
Added two context menu actions: Mark as reviewed and mark as unreviewed.