-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes tests and updates dry validation version #2
Merged
michaelherold
merged 3 commits into
michaelherold:master
from
andrewaguiar:fix-dry-validation
Jan 28, 2017
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
cache: bundler | ||
language: ruby | ||
rvm: | ||
- 2.0 | ||
- 2.1 | ||
- 2.2 | ||
- 2.3.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,7 @@ def assurances | |
# include Interactor::Contracts | ||
# | ||
# assures do | ||
# attr(:person, &:filled?) | ||
# required(:person).filled | ||
# end | ||
# | ||
# def call | ||
|
@@ -68,7 +68,7 @@ def default_violation_handler | |
# include Interactor::Contracts | ||
# | ||
# expects do | ||
# attr(:name, &:filled?) | ||
# required(:name).filled | ||
# end | ||
# | ||
# def call | ||
|
@@ -102,7 +102,7 @@ def expectations | |
# include Interactor::Contracts | ||
# | ||
# expects do | ||
# attr(:name, &:filled?) | ||
# required(:name).filled | ||
# end | ||
# | ||
# on_violation do |violations| | ||
|
@@ -164,7 +164,7 @@ def define_assurances_hook | |
|
||
after do | ||
assurances = self.class.assurances.new | ||
result = assurances.call(context) | ||
result = assurances.call(context.to_h) | ||
|
||
unless result.success? | ||
violations = result.messages.map do |property, messages| | ||
|
@@ -189,7 +189,7 @@ def define_expectations_hook | |
|
||
before do | ||
expectations = self.class.expectations.new | ||
result = expectations.call(context) | ||
result = expectations.call(context.to_h) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above with the other call to |
||
|
||
unless result.success? | ||
violations = result.messages.map do |property, messages| | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
require "codeclimate-test-reporter" | ||
CodeClimate::TestReporter.start | ||
require 'simplecov' | ||
SimpleCov.start | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should get the |
||
|
||
if ENV["COVERAGE"] || ENV["CI"] | ||
require "simplecov" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this throwing an error? Since the
Interactor::Context
object is based onOpenStruct
, it used to be handled automatically bydry-validation
. I would rather rely ondry-validation
's handling ofOpenStruct
s if possible.I'm guessing it was due to how the
required
macro works?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, when I started testing it it was raising a
NoMethodError: undefined method
key?' for, it seems dry-validation started checking for keys using
#key?` method which doesn't exist in OpenStruct neither Context.