Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Danger as a collaboration tool #4

Merged
merged 4 commits into from
Jan 28, 2017
Merged

Add Danger as a collaboration tool #4

merged 4 commits into from
Jan 28, 2017

Commits on Jan 28, 2017

  1. Add Danger as a collaboration tool 

    Danger helps open source maintainers to ensure that certain things are
done by contributors. This helps the maintainers more easily check to
make sure that contributors (including themselves) are following the
contributing guidelines.
    @michaelherold
    michaelherold committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    a494fec View commit details
    Browse the repository at this point in the history

  2. Update RubyGems prior to installing bundle 

    By enabled Danger, we enable the installation of Rubocop on the CI
environment. Rubocop depends on the "rainbow" library which has a build
error on certain versions of RubyGems. This has been fixed in newer
versions of RubyGems, so let's just update RubyGems prior to trying to
install anything.

See: ku1ik/rainbow#44
See: rubygems/rubygems#1819
    @michaelherold
    michaelherold committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    a7e61ea View commit details
    Browse the repository at this point in the history

  3. Move Rake into the test group as well 

    This is related to the RakeBuilder problem with building the rainbow
library. Basically, Rake needs to be installed in order to build
external dependencies.

This is an attempt to make sure that Rake is installed.
    @michaelherold
    michaelherold committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    593e0b3 View commit details
    Browse the repository at this point in the history

  4. Switch to test on jruby-9.1.5.0 

    jruby-9.0.0.0 was having build errors with pry, so let's try a newer
version.
    @michaelherold
    michaelherold committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    9eb9236 View commit details
    Browse the repository at this point in the history