Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][Icon with data in buttons] [Parity: b64 encoded image data for button icons does not get rendered] #4902

Closed
adumrewal opened this issue Oct 9, 2020 · 3 comments · Fixed by #4919
Closed

[iOS][Icon with data in buttons] [Parity: b64 encoded image data for button icons does not get rendered] #4902

adumrewal opened this issue Oct 9, 2020 · 3 comments · Fixed by #4919
Assignees
@jwoo-msft
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS
Milestone
20.10

Comments

@adumrewal
Copy link

Platform

What platform is your issue or question related to? (Delete other platforms).

  • iOS=

Author or host

Host - Teams iOS client

Version of SDK

1.2.10

Details

Button with iconUrl in the form of b64 encoded image data does not render the icon. PFA the screenshots and json for clarity.
iOS Visualizer:
Screenshot 2020-10-09 at 1 08 59 PM

Desktop designer:
Screenshot 2020-10-09 at 1 09 11 PM

Card Json:
card1.txt
@adumrewal adumrewal added the Bug label Oct 9, 2020
@ghost ghost added this to the 20.10 milestone Oct 9, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Oct 9, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@ghost ghost removed the Triage-Needed label Oct 10, 2020
@jwoo-msft jwoo-msft modified the milestones: 20.10, 20.11 Oct 10, 2020
@ghost
Copy link

ghost commented Oct 10, 2020

Hi @adumrewal. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

jwoo-msft added a commit that referenced this issue Oct 13, 2020
@jwoo-msft
fixed #4902
04e5e33
@jwoo-msft jwoo-msft mentioned this issue Oct 13, 2020
Merged
@jwoo-msft jwoo-msft added the Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) label Oct 15, 2020
@jwoo-msft jwoo-msft modified the milestones: 20.11, 20.10 Oct 15, 2020
@ghost ghost added the AdaptiveCards v20.10 label Oct 15, 2020
@jwoo-msft jwoo-msft self-assigned this Oct 19, 2020
jwoo-msft added a commit that referenced this issue Oct 21, 2020
@jwoo-msft
Jwoo/ios action set data uri (#4919)
015a3d5 
* fixed #4902

* Updated
@ghost ghost removed the Status-In Code Review label Oct 21, 2020
@ghost ghost added the Status-Fixed label Oct 21, 2020
@ghost
Copy link

ghost commented Oct 31, 2020

🎉AdaptiveCards@2020.10 has been released which fixes this issue.:tada:

Handy links:

rankush pushed a commit to rankush/AdaptiveCards that referenced this issue May 8, 2024
@jwoo-msft
Jwoo/ios action set data uri (microsoft#4919)
84e44e6 
* fixed microsoft#4902

* Updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwoo-msft jwoo-msft

Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS
Projects
None yet
Milestone
20.10
Development

Successfully merging a pull request may close this issue.

Jwoo/ios action set data uri microsoft/AdaptiveCards
3 participants
@jwoo-msft @adumrewal @shalinijoshi19