Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jwoo/ios action set data uri #4919

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Jwoo/ios action set data uri #4919

merged 3 commits into from
Oct 21, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Oct 13, 2020

Related Issue

fixed #4902

Description

images of actions added to dispatch queue for image loading. Actions of ActionSet was not added into dispatch queue.

How Verified

How you verified the fix, including one or all of the following:

  1. Verified with test card
    image

  2. Ran all Scenario cards.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Oct 19, 2020
@ghost ghost assigned RebeccaAnne Oct 19, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Oct 19, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

Hi @RebeccaAnne; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI.

@jwoo-msft jwoo-msft merged commit 015a3d5 into main Oct 21, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-action-set-data-uri branch October 21, 2020 17:52
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Icon with data in buttons] [Parity: b64 encoded image data for button icons does not get rendered]
2 participants