Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Snippet - Add an easier way to inject queue items as part of the snippet config #1403

Closed
MSNev opened this issue Oct 13, 2020 · 3 comments
Closed

[Feature Request] Snippet - Add an easier way to inject queue items as part of the snippet config #1403

MSNev opened this issue Oct 13, 2020 · 3 comments
Assignees
@MSNev
Labels
enhancement released - NPM snippet Snippet update required or suggested
Milestone
2.5.10

Comments

@MSNev
Copy link
Collaborator

MSNev commented Oct 13, 2020

As per the comment in #1332 -
I have been considering providing an easier way to inject queue items as part of the snippet config, but for now the above would be the approach.

Rather than requiring everyone to directly reference the aiSdk.queue array to add callback methods, provide a callback that is executed once the Sdk is successfully loaded and initialized.

Usage of the aiSdk.queue array is problematic as during initialization the value array is actually deleted (become undefined) and if the sdk has already been loaded and initialized by something else injected on to a hosting page then the reference appInsights instance may not actually be the active sdk instance.
@MSNev MSNev self-assigned this Oct 13, 2020
This was referenced Oct 13, 2020
Closed
Open
MSNev pushed a commit that referenced this issue Oct 13, 2020
[BUG] "ReferenceError: method is not defined" from 2.5.5+ #1402
d533df9 
[Feature Request] Snippet - Add an easier way to inject queue items as part of the snippet config #1403
Host JS snippet at the ASPNET CDN #420
@MSNev MSNev mentioned this issue Oct 13, 2020
Merged
MSNev added a commit that referenced this issue Oct 13, 2020
@MSNev
[BUG] "ReferenceError: method is not defined" from 2.5.5+ #1402 (#1405)
c1e444a 
[Feature Request] Snippet - Add an easier way to inject queue items as part of the snippet config #1403
Host JS snippet at the ASPNET CDN #420
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Oct 13, 2020
@MSNev
Copy link
Collaborator Author

MSNev commented Oct 13, 2020

Tagging as "fixed" waiting release even though strictly speaking the snippet can be used as is from the readme
This is more for release tracking when we go to create the release notes.

@MSNev MSNev added this to the 2.5.10 milestone Nov 13, 2020
@MSNev MSNev added released - NPM waiting - CDN deployment and removed fixed - waiting release PR Committed and waiting deployment labels Nov 18, 2020
@MSNev MSNev closed this as completed Jan 5, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Jan 5, 2021

CDN Deployment rolled back due to #1452

@MSNev MSNev reopened this Jan 5, 2021
@MSNev MSNev added snippet Snippet update required or suggested and removed waiting - CDN deployment labels Jan 25, 2021
@MSNev MSNev closed this as completed Jan 25, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
enhancement released - NPM snippet Snippet update required or suggested
Projects
None yet
Milestone
2.5.10
Development

No branches or pull requests
1 participant
@MSNev