Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host JS snippet at the ASPNET CDN #420

Closed
AKachan0v opened this issue Mar 7, 2017 · 5 comments
Closed

Host JS snippet at the ASPNET CDN #420

AKachan0v opened this issue Mar 7, 2017 · 5 comments

Comments

@AKachan0v
Copy link

Hi guys,

we are using of AI for clients side telemetry and the domain which hosts the JS snippet looks a little suspicious ("https://az416426.vo.msecnd.net/scripts/a/ai.0.js"). Every time when I configure our security header I'm worry that the script can be removed to some other place, because this one doesn't look to be very solid.

Can you please put it for ASPNET CDN (for example):

  • it will makes things much easier when we configure security headers (ASPNET CDN is allowed in the most case);
  • also there can be bonus in performance on loading (not sure that it is very important since in most case it will be cached on client side);
@KamilSzostak
Copy link
Contributor

I'm aware that this URL may not look like it's the official one, but it is 😃. And since it's referenced in the snippet and most of our customers are using it, it's hard to change it and we have to support it.

Regarding *2 - the URL is pointing to Azure CDN which helps to distribute the script fast. So the performance gain from using the ASPNET CDN will be minimal. Most probably you can save one DNS call if you're loading other scripts from ASPNET CDN.

We will consider uploading the ai.0.js file to ASPNET CDN and changing the snippet code. But even after that, we will have to support both locations because we cannot guarantee that all users will update to the latest snippet.

MSNev pushed a commit that referenced this issue Oct 13, 2020
[Feature Request] Snippet - Add an easier way to inject queue items as part of the snippet config #1403
Host JS snippet at the ASPNET CDN #420
@MSNev MSNev self-assigned this Oct 13, 2020
MSNev added a commit that referenced this issue Oct 13, 2020
[Feature Request] Snippet - Add an easier way to inject queue items as part of the snippet config #1403
Host JS snippet at the ASPNET CDN #420
@MSNev
Copy link
Collaborator

MSNev commented Oct 13, 2020

Tagging as "fixed" waiting release even though strictly speaking the snippet can be used as is from the readme
This is more for release tracking when we go to create the release notes.

And the new CDN endpoints have actually been live for a few months :-) (while we tested and confirmed their configuration)

@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Oct 13, 2020
@MSNev MSNev added this to the 2.5.10 milestone Nov 16, 2020
@MSNev MSNev added released - NPM waiting - CDN deployment and removed fixed - waiting release PR Committed and waiting deployment labels Nov 18, 2020
@MSNev MSNev closed this as completed Jan 5, 2021
@MSNev
Copy link
Collaborator

MSNev commented Jan 5, 2021

CDN Deployment rolled back due to #1452

@MSNev
Copy link
Collaborator

MSNev commented Jan 25, 2021

Re-closing now that 2.5.11 is fully released

@MSNev MSNev closed this as completed Jan 25, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants