Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance.mark and performance.measure for performance browser tool integration #617

Closed
toddreifsteck opened this issue Jun 6, 2018 · 7 comments

Comments

@toddreifsteck
Copy link

Various performance tools for all major browsers including Edge and Chrome can display performance.mark and performance.measure data in the default tooling. In addition to this, the various native profilers used by the teams that build those browsers allow these events to be viewed.

I'm a performance expert working on the Microsoft Edge team. When working with teams that use AppInsights to measure their performance, we have found that those teams have to do additional work to add performance.mark/measure to their code.

In an ideal world, App Insights would emit these events allowing those websites to easily describe their start/end events that they'd like us to analyze.

@nolanlawson
Copy link

(I'm Todd's colleague on the Microsoft Edge team. 😃) At a minimum, it would be nice if performance.mark/performance.measure could be enabled via query parameter flags or some other mechanism. We rely on marks and measures when doing performance trace analysis.

@MSNev MSNev self-assigned this Feb 4, 2020
MSNev added a commit that referenced this issue Aug 11, 2021
MSNev added a commit that referenced this issue Aug 12, 2021
MSNev added a commit that referenced this issue Aug 12, 2021
MSNev added a commit that referenced this issue Aug 12, 2021
MSNev added a commit that referenced this issue Aug 13, 2021
@MSNev MSNev added this to the 2.7.0-beta milestone Aug 13, 2021
MSNev added a commit that referenced this issue Aug 13, 2021
…tool integration #617 (#1631)

* Add performance.mark and performance.measure for performance browser tool integration #617

* Address PR comments and issues
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Aug 14, 2021
@MSNev
Copy link
Collaborator

MSNev commented Aug 14, 2021

@MSNev MSNev added released - NPM waiting - CDN deployment fixed - waiting release PR Committed and waiting deployment and removed fixed - waiting release PR Committed and waiting deployment released - NPM labels Sep 8, 2021
@MSNev
Copy link
Collaborator

MSNev commented Sep 8, 2021

Waiting for NPMJS Admins to create the new package name so we can publish, this will also be released as a self contained CDN downloadable component, which is a separate deployment than the NPM deployment

@MSNev MSNev added released - NPM and removed fixed - waiting release PR Committed and waiting deployment labels Sep 10, 2021
@MSNev
Copy link
Collaborator

MSNev commented Sep 10, 2021

@MSNev
Copy link
Collaborator

MSNev commented Sep 13, 2021

v2.7.0 is not fully deployed to NPM and all CDN endpoints

@MSNev MSNev closed this as completed Sep 13, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants