Add performance.mark and performance.measure for performance browser tool integration #617 #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
requested review from
ramthi,
xiao-lix,
hectorhdzg,
kryalama and
Karlie-777
MSNev
commented
Aug 11, 2021
MSNev
commented
Aug 11, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Show resolved
Hide resolved
MSNev
force-pushed
the
MSNev/MarkMeasurePerf
branch
3 times, most recently
from
1ccb951
to
2779575
Compare
xiao-lix
reviewed
Aug 13, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Outdated
Show resolved
Hide resolved
xiao-lix
reviewed
Aug 13, 2021
xiao-lix
reviewed
Aug 13, 2021
xiao-lix
reviewed
Aug 13, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Outdated
Show resolved
Hide resolved
xiao-lix
reviewed
Aug 13, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Outdated
Show resolved
Hide resolved
xiao-lix
reviewed
Aug 13, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Outdated
Show resolved
Hide resolved
xiao-lix
reviewed
Aug 13, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Outdated
Show resolved
Hide resolved
xiao-lix
reviewed
Aug 13, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Outdated
Show resolved
Hide resolved
xiao-lix
reviewed
Aug 13, 2021
extensions/applicationinsights-perfmarkmeasure-js/Tests/Unit/src/MarkMeasureTests.ts
Outdated
Show resolved
Hide resolved
xiao-lix
reviewed
Aug 13, 2021
...sions/applicationinsights-perfmarkmeasure-js/src/interfaces/IPerfMarkMeasureConfiguration.ts
Outdated
Show resolved
Hide resolved
|
Read through the PR, can't find anything other than nit stuff 😄 nice feature. 👍 |
xiao-lix
approved these changes
Aug 13, 2021
MSNev
force-pushed
the
MSNev/MarkMeasurePerf
branch
from
ab4fd45
to
1163f1b
Compare
MSNev
force-pushed
the
MSNev/MarkMeasurePerf
branch
from
1163f1b
to
58ea6a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.