Migrate to grunt build #498

KamilSzostak · 2017-08-04T23:34:14Z

Done:

grunt to build ai.min and snippet scripts
grunt module to build the module script
grunt tests to run unit and e2e tests
migrated to TS 2.4.1

TODO:

remove unused files (nuget files, JavaScriptSDK, Interfaces, Module and Tests csproj)
compile with noImplicitAny: true

msftclas · 2017-08-04T23:34:17Z

@KamilSzostak,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

AlexBulankou · 2017-08-07T18:00:06Z

JavaScript/JavaScriptSDK.Interfaces/ITelemetryContext.ts

@@ -58,7 +58,7 @@ module Microsoft.ApplicationInsights {
        * Adds telemetry initializer to the collection. Telemetry initializers will be called one by one
        * before telemetry item is pushed for sending and in the order they were added.


I think it would be useful to modify the comment to include the description of the function signature for telemetry initializer, specifically to indicate when it can return false/true or undefined.

AlexBulankou · 2017-08-07T20:13:49Z

JavaScript/JavaScriptSDK.Tests/CheckinTests/appInsights.tests.ts

+                    this.setUserAgent("Googlebot/2.1");
+                } catch (ex) {
+                    Assert.ok(true, 'cannot run this test in the current setup - try Chrome');
+                    return;


why do we need to catch and ok-return, instead of proceeding as if Beacon API is not supported?

I need at least one Assert otherwise, JQuery fails with an error - "No assertions executed...".

I meant to catch this but proceed with remainder of the test as if Beacon API is not enabled

This test validates if googlebot is detected correctly by the SDK. To do that I need to change the user agent which is not supported in phantomJs. There is nothing to validate if I cannot override the user agent.

The long term plan is to switch from phantomJS to headless Chrome, once it's available which supports user agent overriding.

AlexBulankou · 2017-08-07T20:18:16Z

JavaScript/JavaScriptSDK.Tests/phantomJS.debug.js

@@ -0,0 +1,7 @@
+page = require('webpage').create();
+page.open('file:///E:/Dev/ApplicationInsights-JS/JavaScript/JavaScriptSDK.Tests/E2ETests/E2E.DisableTelemetryTests.htm?hidepassed', function () {


probably not intended to check this in?

Yes, I used this file to debug tests in PhantomJS.

AlexBulankou · 2017-08-07T20:20:48Z

JavaScript/Microsoft.ApplicationInsights.JavaScript.sln

@@ -1,13 +1,9 @@

 Microsoft Visual Studio Solution File, Format Version 12.00


Why do we still need SLN and *PROJ files?

Never mind, I saw the comment that you put in saying this will be removed as part of subsequent changes.

OsvaldoRosado · 2017-08-09T22:06:35Z

.vscode/settings.json

@@ -0,0 +1,8 @@
+{
+    // Use Typescript from node_modules instead of builtin to VSCode


Comments aren't usually valid JSON. Is vscode okay with this?

OsvaldoRosado · 2017-08-09T22:08:00Z

JavaScript/JavaScriptSDK.Tests/CheckinTests/Sender.tests.ts

@@ -1111,6 +1111,10 @@ class SenderTests extends TestClass {
        this.testCase({
            name: "SenderTests: send() is using BeaconAPI sender if the BeaconAPI is enabled",
            test: () => {
+                if (!(<any>navigator).sendBeacon) {


Are there types we can update rather than cast to any?

I think I added that when I was fixing unit tests and forgot to remove it. It's gone now.

OsvaldoRosado · 2017-08-09T22:09:16Z

JavaScript/JavaScriptSDK.Tests/CheckinTests/Telemetry/PageViewPerformance.tests.ts

-                timing.responseStart = 30;
-                timing.responseEnd = 42;
-                timing.loadEventEnd = 60;
+                (<any>timing).navigationStart = 1;


Why is this cast necessary?

PerformanceTiming properties are read-only, to change them I need to cast them to any.
One way to fix this is to remove PerformanceTiming type and create a simple object with required properties. I like strongly typed objects, but in this case casting to any contradicts using a type, doesn't it?

var timing = { navigationStart: 1, connectEnd: 10, requestStart: 11, responseStart: 30, responseEnd: 42, loadEventEnd: 60, };

instead of

var timing = <PerformanceTiming>{}; (<any>timing).navigationStart = 1; (<any>timing).connectEnd = 10; (<any>timing).requestStart = 11; (<any>timing).responseStart = 30; (<any>timing).responseEnd = 42; (<any>timing).loadEventEnd = 60;

How was this working before when it was strongly typed and not casted?

OsvaldoRosado · 2017-08-09T22:13:06Z

tsconfig.json

@@ -0,0 +1,11 @@
+{
+  "compilerOptions": {


Any way to have grunt read from here rather than defining these options in multiple places?

Yes, I tried it at the beginning when I started the migration to grunt and I couldn't get it to work. But now when everything is building and test are passing it was much easier :)

Kamil Szostak added 17 commits May 1, 2017 17:46

Grunt: compile typescript, create source maps

93c9449

Remove old /min folder

4b100da

Update grunt and readme

3c84c34

merge with master

889cbaf

Unit tests should use the bundle folder

5e76cc5

build unit tests

501cae7

merge with master

7d3542d

fix checkin tests

af36ff6

Run tests in phantomJS

7dd2f0b

Fix unit tests

ff2e71f

update release scripts

8c957b1

fix nuget package build

db007c9

snippet script

ebacff2

Fix E2E tests

06afe35

Rename E2E test files

5940adb

remove unused e2e tests

0c70af4

Fix check sdk size script

de376b3

msftclas added the cla-not-required label Aug 4, 2017

fix npm package

7a6f851

KamilSzostak requested review from OsvaldoRosado and AlexBulankou August 7, 2017 18:59

AlexBulankou suggested changes Aug 7, 2017

View reviewed changes

address comments from pr

a6dda8e

OsvaldoRosado reviewed Aug 9, 2017

View reviewed changes

OsvaldoRosado approved these changes Aug 9, 2017

View reviewed changes

AlexBulankou approved these changes Aug 10, 2017

View reviewed changes

Kamil Szostak added 3 commits August 10, 2017 12:05

resolve pr comments

c857c30

Fix XDomainRequest not defined error in unit tests

760bf75

Fix ai.0.js reference in the nuget package

f2e9cf6

KamilSzostak added this to the 1.0.12 milestone Aug 15, 2017

update test iKey

afcc22e

KamilSzostak merged commit c115405 into master Aug 15, 2017

KamilSzostak deleted the gruntBuild branch October 17, 2017 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to grunt build #498

Migrate to grunt build #498

KamilSzostak commented Aug 4, 2017

msftclas commented Aug 4, 2017

AlexBulankou Aug 7, 2017

AlexBulankou Aug 7, 2017

KamilSzostak Aug 7, 2017

AlexBulankou Aug 7, 2017

KamilSzostak Aug 9, 2017

AlexBulankou Aug 7, 2017

KamilSzostak Aug 9, 2017

AlexBulankou Aug 7, 2017

AlexBulankou Aug 7, 2017

OsvaldoRosado Aug 9, 2017

KamilSzostak Aug 10, 2017

OsvaldoRosado Aug 9, 2017

KamilSzostak Aug 10, 2017

OsvaldoRosado Aug 9, 2017

KamilSzostak Aug 10, 2017

OsvaldoRosado Aug 10, 2017

OsvaldoRosado Aug 9, 2017

KamilSzostak Aug 10, 2017

		@@ -58,7 +58,7 @@ module Microsoft.ApplicationInsights {
		* Adds telemetry initializer to the collection. Telemetry initializers will be called one by one
		* before telemetry item is pushed for sending and in the order they were added.

		@@ -0,0 +1,7 @@
		page = require('webpage').create();
		page.open('file:///E:/Dev/ApplicationInsights-JS/JavaScript/JavaScriptSDK.Tests/E2ETests/E2E.DisableTelemetryTests.htm?hidepassed', function () {

		@@ -1,13 +1,9 @@

		Microsoft Visual Studio Solution File, Format Version 12.00

		@@ -0,0 +1,8 @@
		{
		// Use Typescript from node_modules instead of builtin to VSCode

Migrate to grunt build #498

Migrate to grunt build #498

Conversation

KamilSzostak commented Aug 4, 2017

msftclas commented Aug 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment