-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to grunt build #498
Merged
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
93c9449
Grunt: compile typescript, create source maps
4b100da
Remove old /min folder
3c84c34
Update grunt and readme
889cbaf
merge with master
5e76cc5
Unit tests should use the bundle folder
501cae7
build unit tests
7d3542d
merge with master
af36ff6
fix checkin tests
7dd2f0b
Run tests in phantomJS
ff2e71f
Fix unit tests
8c957b1
update release scripts
db007c9
fix nuget package build
ebacff2
snippet script
06afe35
Fix E2E tests
5940adb
Rename E2E test files
0c70af4
remove unused e2e tests
de376b3
Fix check sdk size script
7a6f851
fix npm package
a6dda8e
address comments from pr
c857c30
resolve pr comments
760bf75
Fix XDomainRequest not defined error in unit tests
f2e9cf6
Fix ai.0.js reference in the nuget package
afcc22e
update test iKey
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
// Use Typescript from node_modules instead of builtin to VSCode | ||
"typescript.tsdk": "./node_modules/typescript/lib", | ||
"files.exclude": { | ||
"**/dist": true, | ||
"**/.tscache": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ | ||
// See https://go.microsoft.com/fwlink/?LinkId=733558 | ||
// for the documentation about the tasks.json format | ||
"version": "0.1.0", | ||
"command": "grunt", | ||
"isShellCommand": true, | ||
"showOutput": "always", | ||
"tasks": [ | ||
{ | ||
"taskName": "default", | ||
"args": [], | ||
"isBuildCommand": true, | ||
"problemMatcher": [ | ||
"$lessCompile", | ||
"$tsc", | ||
"$jshint" | ||
] | ||
}, | ||
{ | ||
"taskName": "module", | ||
"args": [], | ||
"isBuildCommand": true, | ||
"problemMatcher": [ | ||
"$lessCompile", | ||
"$tsc", | ||
"$jshint" | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
// Ignore this file. See https://github.com/grunt-ts/grunt-ts/issues/77 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,4 +21,4 @@ module Microsoft.ApplicationInsights { | |
tags: { [name: string]: any }; | ||
data: any; | ||
} | ||
} | ||
} |
7 changes: 3 additions & 4 deletions
7
JavaScript/JavaScriptSDK.Interfaces/Telemetry/ISerializable.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,13 @@ | ||
| ||
module Microsoft.ApplicationInsights { | ||
module Microsoft.ApplicationInsights { | ||
|
||
"use strict"; | ||
|
||
export interface ISerializable { | ||
/** | ||
* The set of fields for a serializeable object. | ||
* The set of fields for a serializable object. | ||
* This defines the serialization order and a value of true/false | ||
* for each field defines whether the field is required or not. | ||
*/ | ||
aiDataContract: any; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1111,6 +1111,10 @@ class SenderTests extends TestClass { | |
this.testCase({ | ||
name: "SenderTests: send() is using BeaconAPI sender if the BeaconAPI is enabled", | ||
test: () => { | ||
if (!(<any>navigator).sendBeacon) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are there types we can update rather than cast to any? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I added that when I was fixing unit tests and forgot to remove it. It's gone now. |
||
(<any>navigator)['sendBeacon'] = (url: any, data: any) => {}; | ||
} | ||
|
||
// enable beacon API and mock sender | ||
var config = this.getDefaultConfig(); | ||
config.isBeaconApiDisabled = () => false; | ||
|
@@ -1134,6 +1138,10 @@ class SenderTests extends TestClass { | |
this.testCase({ | ||
name: "SenderTests: send() is not using BeaconAPI sender if the BeaconAPI is disabled", | ||
test: () => { | ||
if (!(<any>navigator).sendBeacon) { | ||
(<any>navigator)['sendBeacon'] = (url: any, data: any) => {}; | ||
} | ||
|
||
// enable beacon API and mock sender | ||
var config = this.getDefaultConfig(); | ||
config.isBeaconApiDisabled = () => true; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments aren't usually valid JSON. Is vscode okay with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.