Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some config updates #1507

Merged
merged 9 commits into from
Feb 24, 2021
Merged

Some config updates #1507

merged 9 commits into from
Feb 24, 2021

Conversation

trask
Copy link
Member

@trask trask commented Feb 22, 2021

Several things in this PR:

  • Remove the undocumented micrometer reportingIntervalSeconds and log helpful warning if someone is using it.

  • Instead, add preview configuration metricIntervalSeconds that controls all metrics:

         // applies to perf counters, default custom metrics, jmx metrics, and micrometer metrics
         // not sure if we'll be able to have different metric intervals in future OpenTelemetry metrics world,
         // so safer to only allow single interval for now
         public int metricIntervalSeconds = 60;
    
  • Rename the unreleased spring-scheduling instrumentation node to springScheduling to match the style used throughout the json config.

  • Convert instrumentation settings from map to structured, so that new json config warnings will be displayed when using settings that do not exist.

  • Add preview setting to disable quick pulse

  • Make config reload of connection string and sampling percentage opt-in

@trask trask marked this pull request as draft February 22, 2021 03:25
@trask
Copy link
Member Author

trask commented Feb 22, 2021

Converted to draft. #1504 needs to be merged first.

@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2021

This pull request fixes 2 alerts when merging 4cfb332 into 5a75d6d - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@trask trask force-pushed the trask/some-config-updates branch from 4cfb332 to fbac864 Compare February 22, 2021 21:30
@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2021

This pull request fixes 2 alerts when merging fbac864 into 2e0b120 - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@trask trask force-pushed the trask/some-config-updates branch from fbac864 to 8b9c001 Compare February 23, 2021 04:24
@trask trask marked this pull request as ready for review February 23, 2021 05:25
Copy link
Contributor

@kryalama kryalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 473fc3a into master Feb 24, 2021
@trask trask deleted the trask/some-config-updates branch February 24, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants