-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some config updates #1507
Merged
Merged
Some config updates #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted to draft. #1504 needs to be merged first. |
This pull request fixes 2 alerts when merging 4cfb332 into 5a75d6d - view on LGTM.com fixed alerts:
|
trask
force-pushed
the
trask/some-config-updates
branch
from
February 22, 2021 21:30
4cfb332
to
fbac864
Compare
This pull request fixes 2 alerts when merging fbac864 into 2e0b120 - view on LGTM.com fixed alerts:
|
trask
force-pushed
the
trask/some-config-updates
branch
from
February 23, 2021 04:24
fbac864
to
8b9c001
Compare
kryalama
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
...soft/applicationinsights/agent/internal/wasbootstrap/configuration/ConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things in this PR:
Remove the undocumented micrometer
reportingIntervalSeconds
and log helpful warning if someone is using it.Instead, add preview configuration
metricIntervalSeconds
that controls all metrics:Rename the unreleased
spring-scheduling
instrumentation node tospringScheduling
to match the style used throughout the json config.Convert instrumentation settings from map to structured, so that new json config warnings will be displayed when using settings that do not exist.
Add preview setting to disable quick pulse
Make config reload of connection string and sampling percentage opt-in