[Dev] BUG Fix for bitnet integration #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve functionality, fix issues, and update dependencies. The most important changes include updating a submodule, modifying conditions for specific operations, and updating script behavior for model generation.
Submodule Update:
3rdparty/tvm: Updated submodule commit to the latest version. ([3rdparty/tvmL1-R1](https://github.com/microsoft/BitBLAS/pull/141/files#diff-fa909c93fe94e9aa04c9e7f19e5754a2bb274678ad5c6275ee4bf54c6f9b1066L1-R1))Code Enhancements:
bitblas/gpu/matmul_analysis.py: Modified the condition to check fordequantize_infoto ensure it only supportsfloat16data type. ([bitblas/gpu/matmul_analysis.pyL626-R627](https://github.com/microsoft/BitBLAS/pull/141/files#diff-6f289ae4794dea10c7718ec09a9e100a564894c8a93c36559c9fa6d0688553e3L626-R627))bitblas/ops/general_matmul/__init__.py: Added a temporary solution to legalize the dynamic symbolic, with a note to potentially remove it in the future. ([bitblas/ops/general_matmul/__init__.pyR88-R89](https://github.com/microsoft/BitBLAS/pull/141/files#diff-74fe5dd2824cb03a0fb2b0a913a2fc5caeb9c08e5368c318cd32b3af7e6f52edR88-R89))Script Updates:
integration/BitNet/eval_correctness.py: Disabledflash_attention_2and added functionality to quantize the model and compare generated text before and after quantization. ([integration/BitNet/eval_correctness.pyL75-R88](https://github.com/microsoft/BitBLAS/pull/141/files#diff-24610ce0fe8c0977dec03f95f17f709d384085cdb8ff49f86f563dba7dfa5ec4L75-R88))integration/BitNet/maint/create_bitblas_ckpt.py: Disabledflash_attention_2in the model configuration. ([integration/BitNet/maint/create_bitblas_ckpt.pyL71-R71](https://github.com/microsoft/BitBLAS/pull/141/files#diff-8b1a01ecd38f6ed3a87e4974faf672137b4a044a6137bc3ff7854a0d515689efL71-R71))integration/BitNet/maint/generate_bitnet_model_bitblas_format.sh: Added a check to create theSAVED_MODEL_DIRdirectory if it does not exist. ([integration/BitNet/maint/generate_bitnet_model_bitblas_format.shR21-R23](https://github.com/microsoft/BitBLAS/pull/141/files#diff-d6095b66d1b0492e71833fb5a0f99593bf2261720a96ab43811a1b32f136b6c1R21-R23))Dependency Update:
integration/BitNet/requirements.txt: Addedtransformers==4.40to the requirements. ([integration/BitNet/requirements.txtR3](https://github.com/microsoft/BitBLAS/pull/141/files#diff-c274b4a63b1dc11eb5c71badfa85865c12befc3563dfa52d57f5c4655809c155R3))