Code

[Dev] BUG Fix for bitnet integration#141

Code

Merged

LeiWang1999 merged 189 commits intomicrosoft:mainmicrosoft/BitBLAS:mainfrom LeiWang1999:update_transformLeiWang1999/MSBitBLAS:update_transformCopy head branch name to clipboardAug 13, 2024

+16-8

Commits

Commits on Jul 5, 2024

• Refactor BatchMatMulEmitter and BatchMatMulSelector for improved readability and maintainability

  LeiWang1999

  committed
  d8884e6

  Copy full SHA for d8884e6

• Refactor import statements for improved readability and maintainability

  LeiWang1999

  committed
  fc84173

  Copy full SHA for fc84173

• Refactor import statements for improved readability and maintainability

  LeiWang1999

  committed
  02f64de

  Copy full SHA for 02f64de

• disable failure email for ci

  LeiWang1999

  committed
  397eee6

  Copy full SHA for 397eee6

Commits on Jul 6, 2024

• remove email notifications.

  LeiWang1999

  committed
  20f6ad1

  Copy full SHA for 20f6ad1

• move relax pass from testing to mlc_llm

  LeiWang1999

  committed
  b93c394

  Copy full SHA for b93c394

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into main

  LeiWang1999

  committed
  ba6a6df

  Copy full SHA for ba6a6df

• Refactor scripts with se check_eual_ref_scripts_with_emitter function

  LeiWang1999

  committed
  257693a

  Copy full SHA for 257693a

• Lint Fix

  LeiWang1999

  committed
  9bb7f49

  Copy full SHA for 9bb7f49

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into main

  LeiWang1999

  committed
  39e7614

  Copy full SHA for 39e7614

• Refactor scripts with se check_eual_ref_scripts_with_emitter function

  LeiWang1999

  committed
  93eb5a5

  Copy full SHA for 93eb5a5

• bug fix in test

  LeiWang1999

  committed
  aa66a90

  Copy full SHA for aa66a90

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  ae14a53

  Copy full SHA for ae14a53

• lint fix.

  LeiWang1999

  committed
  79b08e4

  Copy full SHA for 79b08e4

Commits on Jul 7, 2024

• test cuda i4 kernel

  LeiWang1999

  committed
  86fd036

  Copy full SHA for 86fd036

• Refactor copyright notice in i4matmul.hpp

  LeiWang1999

  committed
  6b73a21

  Copy full SHA for 6b73a21

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  0ba90c1

  Copy full SHA for 0ba90c1

• Refactor BitBLASLinear test module for improved readability and maintainability

  LeiWang1999

  committed
  086d208

  Copy full SHA for 086d208

Commits on Jul 8, 2024

• refactor test as version below python 3.9 cannot handle int32 overflow.

  LeiWang1999

  committed
  47a3abd

  Copy full SHA for 47a3abd

• format lint for test

  LeiWang1999

  committed
  024b247

  Copy full SHA for 024b247

• Refactor test_int4b_fp16_convert.py for improved readability and maintainability

  LeiWang1999

  committed
  bfedeaa

  Copy full SHA for bfedeaa

• remove unused design file

  LeiWang1999

  committed
  e672a23

  Copy full SHA for e672a23

• move tile device from package to base

  LeiWang1999

  committed
  21e5430

  Copy full SHA for 21e5430

• dummy impl for codegen

  LeiWang1999

  committed
  fd11940

  Copy full SHA for fd11940

• Refactor file structure for ladder_permutate module

  LeiWang1999

  committed
  9ccfa85

  Copy full SHA for 9ccfa85

• Refactor backend class and fix typos in comments

  LeiWang1999

  committed
  7c7d73e

  Copy full SHA for 7c7d73e

• Deep refactor Lib related code.

  LeiWang1999

  committed
  47d5fc5

  Copy full SHA for 47d5fc5

Commits on Jul 10, 2024

• remove ci pull.

  LeiWang1999

  committed
  53dd0dd

  Copy full SHA for 53dd0dd

• LintFix

  LeiWang1999

  committed
  d58ac43

  Copy full SHA for d58ac43

• refactor builder for whl build

  LeiWang1999

  committed
  37cb07c

  Copy full SHA for 37cb07c

Commits on Jul 11, 2024

• Refactor TIRWrapper.wrap() method to include an assertion for the optimized module

  LeiWang1999

  committed
  f5b9999

  Copy full SHA for f5b9999

• Refactor lib_generator to set library and source paths

  LeiWang1999

  committed
  fb78244

  Copy full SHA for fb78244

• lint fix

  LeiWang1999

  committed
  706e227

  Copy full SHA for 706e227

Commits on Jul 16, 2024

• BitNet vllm integration

  LeiWang1999

  committed
  63f5515

  Copy full SHA for 63f5515

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  de91c0d

  Copy full SHA for de91c0d

• chore: update codespell to version 2.3.0

  LeiWang1999

  committed
  b9655fd

  Copy full SHA for b9655fd

• Lintfix

  LeiWang1999

  committed
  fff385f

  Copy full SHA for fff385f

Commits on Jul 18, 2024

• Bump version to 0.0.1.dev13

  LeiWang1999

  committed
  72a98e7

  Copy full SHA for 72a98e7

• lint fix

  LeiWang1999

  committed
  5646ab5

  Copy full SHA for 5646ab5

Commits on Jul 21, 2024

• disable fast decoding [u]int4xint8 by default.

  LeiWang1999

  committed
  b965863

  Copy full SHA for b965863

• optimize from dict design in Hint

  LeiWang1999

  committed
  1198fc7

  Copy full SHA for 1198fc7

• Implement SplitK

  LeiWang1999

  committed
  014213c

  Copy full SHA for 014213c

• bitnet benchmark generation.

  LeiWang1999

  committed
  e0ca752

  Copy full SHA for e0ca752

• Add benchmark script for BitNet integration

  LeiWang1999

  committed
  81b9cf0

  Copy full SHA for 81b9cf0

• AtomicAdd Support

  LeiWang1999

  committed
  02edc0b

  Copy full SHA for 02edc0b

• LintFix

  LeiWang1999

  committed
  1a70c2d

  Copy full SHA for 1a70c2d

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  28d851c

  Copy full SHA for 28d851c

• ci fix when 3rdparty tvm is initialized.

  LeiWang1999

  committed
  c447a95

  Copy full SHA for c447a95

• bug fix for setup

  LeiWang1999

  committed
  79a001b

  Copy full SHA for 79a001b

• fix a bug in block reduce

  LeiWang1999

  committed
  31813b2

  Copy full SHA for 31813b2

• typo fix

  LeiWang1999

  committed
  78b6a3d

  Copy full SHA for 78b6a3d

Commits on Jul 22, 2024

• BUG Fix for block reduce.

  LeiWang1999

  committed
  9c55218

  Copy full SHA for 9c55218

• Lint fix

  LeiWang1999

  committed
  1aa8868

  Copy full SHA for 1aa8868

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  22f70bf

  Copy full SHA for 22f70bf

• Refactor block reduce schedule template

  LeiWang1999

  committed
  5f082a5

  Copy full SHA for 5f082a5

• transform branch from bitblas to bitblas_tl

  LeiWang1999

  committed
  b4fb31e

  Copy full SHA for b4fb31e

• Fix subproject commit reference in 3rdparty/tvm

  LeiWang1999

  committed
  35eaa00

  Copy full SHA for 35eaa00

• chore: update submodule branch from bitblas to bitblas_tl

  LeiWang1999

  committed
  254dd74

  Copy full SHA for 254dd74

• force update config.cmake

  LeiWang1999

  committed
  31a44aa

  Copy full SHA for 31a44aa

• Bug fix

  LeiWang1999

  committed
  427800e

  Copy full SHA for 427800e

• Fix subproject commit reference in 3rdparty/cutlass

  LeiWang1999

  committed
  96db111

  Copy full SHA for 96db111

• chore: Add submodule for cutlass library

  LeiWang1999

  committed
  38b251a

  Copy full SHA for 38b251a

• update tl cutlass path

  LeiWang1999

  committed
  87d1c5a

  Copy full SHA for 87d1c5a

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  6200b1e

  Copy full SHA for 6200b1e

• Refactor BitBLASLinear test module for improved readability and maintainability

  LeiWang1999

  committed
  0ffe0b5

  Copy full SHA for 0ffe0b5

• format fix

  LeiWang1999

  committed
  8e08e77

  Copy full SHA for 8e08e77

• Copy CUTLASS to the package directory

  LeiWang1999

  committed
  df05a64

  Copy full SHA for df05a64

• Refactor setup.py to include additional TVM header files

  LeiWang1999

  committed
  4f529c5

  Copy full SHA for 4f529c5

Commits on Jul 23, 2024

• lint fix

  LeiWang1999

  committed
  d02bbc7

  Copy full SHA for d02bbc7

• bug fix

  LeiWang1999

  committed
  cffe3fd

  Copy full SHA for cffe3fd

• Refactor BitBLASLinear test module for improved readability and maintainability

  LeiWang1999

  committed
  a8bed74

  Copy full SHA for a8bed74

• Implement Matmul Benchmark Design

  LeiWang1999

  committed
  d4eb5fd

  Copy full SHA for d4eb5fd

• chore: Update BitBLAS Matmul benchmark script

  LeiWang1999

  committed
  4c6c2c1

  Copy full SHA for 4c6c2c1

• lint fix

  LeiWang1999

  committed
  0acaca1

  Copy full SHA for 0acaca1

• Refactor BitBLASMatmulOpsBenchmark for improved readability and maintainability

  LeiWang1999

  committed
  54d2227

  Copy full SHA for 54d2227

• Refactor BitBLASMatmulOpsBenchmark to disable tuning during benchmark run

  LeiWang1999

  committed
  c2edefb

  Copy full SHA for c2edefb

• lint fix

  LeiWang1999

  committed
  e0bc723

  Copy full SHA for e0bc723

• Benchmark bot test

  LeiWang1999

  committed
  a4e68d1

  Copy full SHA for a4e68d1

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  df7e9aa

  Copy full SHA for df7e9aa

• Refactor BitBLASMatmulOpsBenchmark to disable tuning during benchmark run

  LeiWang1999

  committed
  1c03365

  Copy full SHA for 1c03365

• Refactor BitBLASMatmulOpsBenchmark to disable tuning during benchmark run

  LeiWang1999

  committed
  4f319fc

  Copy full SHA for 4f319fc

• Refactor BitBLASMatmulOpsBenchmark to disable tuning during benchmark run

  LeiWang1999

  committed
  a8833d4

  Copy full SHA for a8833d4

• Refactor BitBLASMatmulOpsBenchmark to disable tuning during benchmark run

  LeiWang1999

  committed
  803f6c6

  Copy full SHA for 803f6c6

• Refactor BitBLASMatmulOpsBenchmark to disable tuning during benchmark run

  LeiWang1999

  committed
  df4572b

  Copy full SHA for df4572b

• int8 test case

  LeiWang1999

  committed
  45ded45

  Copy full SHA for 45ded45

• Refactor compare_benchmark.py to handle missing benchmark results gracefully

  LeiWang1999

  committed
  4229676

  Copy full SHA for 4229676

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  b883290

  Copy full SHA for b883290

• ci fix

  LeiWang1999

  committed
  476ffee

  Copy full SHA for 476ffee

• disable ci for test benchmark

  LeiWang1999

  committed
  9bd34ff

  Copy full SHA for 9bd34ff

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  e86f4b2

  Copy full SHA for e86f4b2

• Refactor BitBLASMatmulOpsBenchmark to disable tuning during benchmark run

  LeiWang1999

  committed
  75f3dd9

  Copy full SHA for 75f3dd9

• remove cli installation

  LeiWang1999

  committed
  79e04aa

  Copy full SHA for 79e04aa

• chore: Create virtual environment and install dependencies for benchmark

  LeiWang1999

  committed
  cdd3345

  Copy full SHA for cdd3345

• Merge branch 'main' into dev

  LeiWang1999

  authored
  f099938

  Copy full SHA for f099938

• chore: Update benchmark workflow to include comparison step

  LeiWang1999

  committed
  f211ad4

  Copy full SHA for f211ad4

Commits on Jul 24, 2024

• Lint fix

  LeiWang1999

  committed
  ddde02a

  Copy full SHA for ddde02a

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  8045ce9

  Copy full SHA for 8045ce9

• Merge branch 'dev' of https://github.com/LeiWang1999/MSBitBLAS into dev

  LeiWang1999

  committed
  21aee89

  Copy full SHA for 21aee89

Commits on Jul 25, 2024

• upodate tvm cmmit

  LeiWang1999

  committed
  ef1b158

  Copy full SHA for ef1b158

Commits on Jul 30, 2024

• Imporve lower warp memory pass

  LeiWang1999

  committed
  a8d8841

  Copy full SHA for a8d8841

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  686b929

  Copy full SHA for 686b929

• Bug fix

  LeiWang1999

  committed
  7736c38

  Copy full SHA for 7736c38

Commits on Jul 31, 2024

• Enhance to support warp schedule.

  LeiWang1999

  committed
  199affc

  Copy full SHA for 199affc

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  9d0c25d

  Copy full SHA for 9d0c25d

• Enhance LOP3 Instructions

  LeiWang1999

  committed
  7c1f52e

  Copy full SHA for 7c1f52e

• Enhance LOP3 Instructions

  LeiWang1999

  committed
  d1b2bc7

  Copy full SHA for d1b2bc7

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  2aac6d0

  Copy full SHA for 2aac6d0

• add test for stage3 propagate

  LeiWang1999

  committed
  802abde

  Copy full SHA for 802abde

• implement propagate func

  LeiWang1999

  committed
  d339037

  Copy full SHA for d339037

• Stage3 Ladder Permutate integration

  LeiWang1999

  committed
  0f6a033

  Copy full SHA for 0f6a033

• get_ladder_stage3_propagate

  LeiWang1999

  committed
  00ec916

  Copy full SHA for 00ec916

• comments benchmark scirpts as the setting is too big

  LeiWang1999

  committed
  5316577

  Copy full SHA for 5316577

• ci fix for benchmark

  LeiWang1999

  committed
  dd070f9

  Copy full SHA for dd070f9

• lint fix

  LeiWang1999

  committed
  6fcc368

  Copy full SHA for 6fcc368

• chore: Update benchmark workflow to trigger on pull request comments

  LeiWang1999

  committed
  705580b

  Copy full SHA for 705580b

Commits on Aug 1, 2024

• Add LDMatrix Transform 3

  LeiWang1999

  committed
  c5ba940

  Copy full SHA for c5ba940

• Support GPTQ Test

  LeiWang1999

  committed
  1566990

  Copy full SHA for 1566990

• Fuse BlockReduce Schedule

  LeiWang1999

  committed
  c6c70ef

  Copy full SHA for c6c70ef

• Support mma propagate 3

  LeiWang1999

  committed
  36128f3

  Copy full SHA for 36128f3

• Support MMA Propagate Stage 3

  LeiWang1999

  committed
  23ff5f4

  Copy full SHA for 23ff5f4

• Lint Fix

  LeiWang1999

  committed
  de3bf08

  Copy full SHA for de3bf08

• Merge block reduce for dequantze config.

  LeiWang1999

  committed
  d9830ba

  Copy full SHA for d9830ba

Commits on Aug 2, 2024

• fix codeql

  LeiWang1999

  committed
  e5a4485

  Copy full SHA for e5a4485

Commits on Aug 4, 2024

• chore: Update submodule reference to latest commit

  LeiWang1999

  committed
  a04282b

  Copy full SHA for a04282b

• chore: Disable common subexpression elimination in TIR passes

  LeiWang1999

  committed
  314d3e9

  Copy full SHA for 314d3e9

• Lint Fix

  LeiWang1999

  committed
  f7d33bb

  Copy full SHA for f7d33bb

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  db633ed

  Copy full SHA for db633ed

• 4bit related lop3 updates.

  LeiWang1999

  committed
  201155a

  Copy full SHA for 201155a

• lint fix

  LeiWang1999

  committed
  2b73662

  Copy full SHA for 2b73662

• gptq test fix

  LeiWang1999

  committed
  1a6a0fd

  Copy full SHA for 1a6a0fd

• Fix for test

  LeiWang1999

  committed
  e84e3ef

  Copy full SHA for e84e3ef

• lint fix

  LeiWang1999

  committed
  f0fbb55

  Copy full SHA for f0fbb55

• lint fix

  LeiWang1999

  committed
  bf30688

  Copy full SHA for bf30688

• typofix

  LeiWang1999

  committed
  9a360ba

  Copy full SHA for 9a360ba

Commits on Aug 5, 2024

• QuantCompress Test

  LeiWang1999

  committed
  ee94536

  Copy full SHA for ee94536

• chore: Refactor quant_compress_impl.py for readability and maintainability

  LeiWang1999

  committed
  930cd76

  Copy full SHA for 930cd76

• Enhance docs to update latest works.

  LeiWang1999

  committed
  8c24776

  Copy full SHA for 8c24776

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into dev

  LeiWang1999

  committed
  c018e3c

  Copy full SHA for c018e3c

• Refactor weight executors in Matmul class for improved readability and maintainability

  LeiWang1999

  committed
  38f1713

  Copy full SHA for 38f1713

• Refactor weight executors in Matmul class for improved readability and maintainability

  LeiWang1999

  committed
  4a578ce

  Copy full SHA for 4a578ce

• Refactor weight executors in Matmul class for improved readability and maintainability

  LeiWang1999

  committed
  4e7126b

  Copy full SHA for 4e7126b

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into update_transform

  LeiWang1999

  committed
  de9fd2e

  Copy full SHA for de9fd2e

• removed legacy operator

  LeiWang1999

  committed
  e405aa2

  Copy full SHA for e405aa2

• Refactor weight executors in Matmul class for improved readability and maintainability

  LeiWang1999

  committed
  5709db1

  Copy full SHA for 5709db1

• LintFix

  LeiWang1999

  committed
  2d90e7b

  Copy full SHA for 2d90e7b

• Fix GPTQ Repack with the latest weight transform

  LeiWang1999

  committed
  c2d2cfa

  Copy full SHA for c2d2cfa

• lint fix

  LeiWang1999

  committed
  ed6a0a1

  Copy full SHA for ed6a0a1

• bug fix for rescale dequantize

  LeiWang1999

  committed
  d23ab47

  Copy full SHA for d23ab47

• test fix

  LeiWang1999

  committed
  af16059

  Copy full SHA for af16059

• typo fix

  LeiWang1999

  committed
  ac316fd

  Copy full SHA for ac316fd

• lint fix

  LeiWang1999

  committed
  71c1d6e

  Copy full SHA for 71c1d6e

• Set default weight propagate kind into LDMatrixTransform

  LeiWang1999

  committed
  b2892af

  Copy full SHA for b2892af

• lint fix

  LeiWang1999

  committed
  3135a01

  Copy full SHA for 3135a01

• bug fix

  LeiWang1999

  committed
  a30dae9

  Copy full SHA for a30dae9

Commits on Aug 6, 2024

• bug fix for test

  LeiWang1999

  committed
  b913d26

  Copy full SHA for b913d26

• set default to stage3

  LeiWang1999

  committed
  d96fa3d

  Copy full SHA for d96fa3d

• revert change

  LeiWang1999

  committed
  e0f068c

  Copy full SHA for e0f068c

• lint fix

  LeiWang1999

  committed
  907d434

  Copy full SHA for 907d434

Commits on Aug 7, 2024

• case fix

  LeiWang1999

  committed
  e7c805a

  Copy full SHA for e7c805a

• bug fix

  LeiWang1999

  committed
  7a16e5a

  Copy full SHA for 7a16e5a

• fix for legalize

  LeiWang1999

  committed
  8c666ac

  Copy full SHA for 8c666ac

• bug fix

  LeiWang1999

  committed
  ce79943

  Copy full SHA for ce79943

• chore: Clear global operator cache before running tests

  LeiWang1999

  committed
  e6c5eec

  Copy full SHA for e6c5eec

Commits on Aug 9, 2024

• revert optimize_stratety into SingleBatchDecodeOnly

  LeiWang1999

  committed
  4e8ab23

  Copy full SHA for 4e8ab23

• typofix

  LeiWang1999

  committed
  8177e2f

  Copy full SHA for 8177e2f

• update benchmark scripts

  LeiWang1999

  committed
  113e485

  Copy full SHA for 113e485

• chore: Refactor benchmark scripts and fix typos

  LeiWang1999

  committed
  46b2d7d

  Copy full SHA for 46b2d7d

• fix for testing

  LeiWang1999

  committed
  9ecbb48

  Copy full SHA for 9ecbb48

• lint fix

  LeiWang1999

  committed
  fb128ed

  Copy full SHA for fb128ed

• fix import.

  LeiWang1999

  committed
  9b5e106

  Copy full SHA for 9b5e106

• typo

  LeiWang1999

  committed
  54b4044

  Copy full SHA for 54b4044

• operator benchmark

  LeiWang1999

  committed
  23f88b7

  Copy full SHA for 23f88b7

• optimize

  LeiWang1999

  committed
  bcffc49

  Copy full SHA for bcffc49

• always with shared.dyn

  LeiWang1999

  committed
  8b5f083

  Copy full SHA for 8b5f083

• optimize cache.

  LeiWang1999

  committed
  54b5d3f

  Copy full SHA for 54b5d3f

• dsl fix

  LeiWang1999

  committed
  4289d7b

  Copy full SHA for 4289d7b

• Merge branch 'main' into update_transform

  LeiWang1999

  authored
  72a1863

  Copy full SHA for 72a1863

• tqdm

  LeiWang1999

  committed
  2327e14

  Copy full SHA for 2327e14

• Merge branch 'update_transform' of https://github.com/LeiWang1999/MSBitBLAS into update_transform

  LeiWang1999

  committed
  40a9b04

  Copy full SHA for 40a9b04

• chore: Add serialize_results method to benchmark_matmul_strategies.py

  LeiWang1999

  committed
  a16ee62

  Copy full SHA for a16ee62

Commits on Aug 10, 2024

• fix performance issue for dynamic async copy

  LeiWang1999

  committed
  63fc654

  Copy full SHA for 63fc654

• chore: Refactor benchmark_matmul_strategies.py for improved performance and code readability

  LeiWang1999

  committed
  d37d09f

  Copy full SHA for d37d09f

• bug fix

  LeiWang1999

  committed
  d4d4603

  Copy full SHA for d4d4603

Commits on Aug 12, 2024

• update readme

  LeiWang1999

  committed
  1816526

  Copy full SHA for 1816526

Commits on Aug 13, 2024

• disable block reduce for int8

  LeiWang1999

  committed
  b81a3a8

  Copy full SHA for b81a3a8

• Merge branch 'main' of https://github.com/Microsoft/BitBLAS into update_transform

  LeiWang1999

  committed
  9cde970

  Copy full SHA for 9cde970

• bugfix for bitnet

  LeiWang1999

  committed
  1c89c60

  Copy full SHA for 1c89c60

• annotatte todo.

  LeiWang1999

  committed
  cfda648

  Copy full SHA for cfda648

• lint fix

  LeiWang1999

  committed
  83b99c4

  Copy full SHA for 83b99c4