Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Fix creation flow radio and template text color #2483

Merged
merged 5 commits into from
Apr 6, 2020

Conversation

corinagum
Copy link
Contributor

Description

  • Removes extraneous aria-requireds from a previous commit
  • Changes creation flow dialog's template text color for a11y (stopgap; discussed with @DesignPolice)
  • Adds label to bot creation radio group for a11y

Task Item

Fixes #2018 - a11y fix for creation flow dialog
Fixes: #2177 - Change template boxes to black text as stopgap

Screenshots

image

@a-b-r-o-w-n a-b-r-o-w-n merged commit e0e7477 into microsoft:master Apr 6, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* microsoft#2177 Fix template box text contrast ratio

* microsoft#2018 Fix creation flow dialog radio a11y

* Remove extraneous aria-required from previous commit

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants