-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility][Visual Requirement-Create from template]: Luminosity ratio of all templates within 'Create from template' is less than 4.5:1. #2177
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks for the Tag @corinagum, I was wondering when this one would come up. It is a hack of a old design, that was altered just to get things moving. Let me find out if they want to alter the hack, or implement an actual fix that we have. I will touch back ASAP |
Related to #1728 , so there will probably be a decent amount of discussion before a spec is ready. Moving back to To Do |
Thanks Corina - @cwhitten and @mareekuh - Lets talk about this in Stand Up today if we have time or we have someone waiting to fix it. Update: We are going to hold on this - there is a design submitted already to fix this, rather than doing it twice we will just wait to fix. That said if it is just changing a # - you could make the text on those tiles Black and it will give us enough contrast. |
@DesignPolice roger that, will do. Thanks for checking up! |
Hi Corina ,We will validate this bug and share update asap. |
As checked, still the issue is not fixed yet. Still CCA is 3.8:1. |
I have done a fresh build of Composer and verified this fix. Please re-verify on your side. |
@corinagum Checked on the latest build and the issue is resolved. So, HCL is closing the issue. The contrast ratio is: 17.6:1 |
* microsoft#2177 Fix template box text contrast ratio * microsoft#2018 Fix creation flow dialog radio a11y * Remove extraneous aria-required from previous commit Co-authored-by: Andy Brown <asbrown002@gmail.com>
User Experience:
Users with low vision or sensitive to low luminosity ratio colors would be impacted as the visibility of templates is less than the standard luminosity ratio of 4.5:1.
Test Environment:
Environment: Chromium Edge (Anaheim) + Narrator
Build Version: 2004 (OS Build 19564.1005)
Microsoft Edge Version: 82.0.425.0 (Official build) canary (64-bit)
Test URL: http://localhost:3000/home
Repro Steps:
Actual:
Luminosity ratio of all templates within 'Create from template' is less than 4.5:1.
Expected:
Luminosity ratio should be >=4.5:1 for all templates within 'Create from template'.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/Doc.aspx?sourcedoc=%7BA78189A8-A3DC-42C4-A464-A051EBBBD5DF%7D&file=Guideline%2017A%20-%20Contrast%20(Minimum)%20When%20Conveying%20Information.docx&action=default&mobileredirect=true
Attachment:
MAS1.4.3_Create From template.zip
The text was updated successfully, but these errors were encountered: