Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Visual Requirement-Create from template]: Luminosity ratio of all templates within 'Create from template' is less than 4.5:1. #2177

Closed
ShellySoni opened this issue Mar 5, 2020 · 12 comments

Comments

@ShellySoni
Copy link

ShellySoni commented Mar 5, 2020

User Experience:
Users with low vision or sensitive to low luminosity ratio colors would be impacted as the visibility of templates is less than the standard luminosity ratio of 4.5:1.

Test Environment:
Environment: Chromium Edge (Anaheim) + Narrator
Build Version: 2004 (OS Build 19564.1005)​​
Microsoft Edge Version: 82.0.425.0 (Official build) canary (64-bit)​
Test URL: http://localhost:3000/home

Repro Steps:

  1. Open URL: http://localhost:3000/home
  2. Navigate on homepage with tab key up to 'New' button and press enter on it.
  3. 'Create from scratch' pop up will open.
  4. Select 'Create from Template' radio button and then press tab key to land on its first template i.e. Echo bot.
  5. Observe the CCA with color contrast analyzer and find the issue.

Actual:
Luminosity ratio of all templates within 'Create from template' is less than 4.5:1.

Expected:
Luminosity ratio should be >=4.5:1 for all templates within 'Create from template'.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/Doc.aspx?sourcedoc=%7BA78189A8-A3DC-42C4-A464-A051EBBBD5DF%7D&file=Guideline%2017A%20-%20Contrast%20(Minimum)%20When%20Conveying%20Information.docx&action=default&mobileredirect=true

Attachment:
MAS1.4.3_Create From template.zip

@corinagum

This comment has been minimized.

@corinagum corinagum added Needs review Info requested and removed Needs-triage A new issue that require triage Needs review labels Mar 5, 2020
@corinagum

This comment has been minimized.

@Padmini171991
Copy link

MAS1 4 3_Create From template

Attaching screenshot here. Somehow the zip file got dragged on top of User Experience.

@corinagum

This comment has been minimized.

@corinagum corinagum self-assigned this Mar 17, 2020
@DesignPolice
Copy link

Thanks for the Tag @corinagum, I was wondering when this one would come up. It is a hack of a old design, that was altered just to get things moving. Let me find out if they want to alter the hack, or implement an actual fix that we have.

I will touch back ASAP

@corinagum
Copy link
Contributor

corinagum commented Mar 17, 2020

Related to #1728 , so there will probably be a decent amount of discussion before a spec is ready. Moving back to To Do

@DesignPolice
Copy link

DesignPolice commented Mar 17, 2020

Thanks Corina - @cwhitten and @mareekuh - Lets talk about this in Stand Up today if we have time or we have someone waiting to fix it.

Update: We are going to hold on this - there is a design submitted already to fix this, rather than doing it twice we will just wait to fix. That said if it is just changing a # - you could make the text on those tiles Black and it will give us enough contrast.

@corinagum
Copy link
Contributor

@DesignPolice roger that, will do. Thanks for checking up!

corinagum pushed a commit to corinagum/BotFramework-Composer that referenced this issue Mar 24, 2020
corinagum added a commit to corinagum/BotFramework-Composer that referenced this issue Apr 2, 2020
a-b-r-o-w-n added a commit that referenced this issue Apr 6, 2020
* #2177 Fix template box text contrast ratio

* #2018 Fix creation flow dialog radio a11y

* Remove extraneous aria-required from previous commit

Co-authored-by: Andy Brown <asbrown002@gmail.com>
@corinagum corinagum added the Fixed label Apr 6, 2020
@awalia13
Copy link

awalia13 commented Apr 7, 2020

Hi Corina ,We will validate this bug and share update asap.

@ashish315
Copy link

ashish315 commented Apr 8, 2020

As checked, still the issue is not fixed yet. Still CCA is 3.8:1.

@ashish315 ashish315 removed the Fixed label Apr 8, 2020
@corinagum
Copy link
Contributor

I have done a fresh build of Composer and verified this fix. Please re-verify on your side.

@corinagum corinagum added the Fixed label Apr 8, 2020
@ashish315
Copy link

@corinagum Checked on the latest build and the issue is resolved. So, HCL is closing the issue.
Current CCA result-
Foreground:#000000
Background:#EBEBEB

The contrast ratio is: 17.6:1

@ashish315 ashish315 removed the Fixed label Apr 9, 2020
@corinagum corinagum added the Fixed label Apr 9, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this issue Jun 15, 2021
* microsoft#2177 Fix template box text contrast ratio

* microsoft#2018 Fix creation flow dialog radio a11y

* Remove extraneous aria-required from previous commit

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants