Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation flow #2482

Closed
wants to merge 67 commits into from
Closed

Creation flow #2482

wants to merge 67 commits into from

Conversation

corinagum
Copy link
Contributor

Description

  • Removes extraneous aria-requireds from a previous commit
  • Changes creation flow dialog's template text color for a11y (stopgap; discussed with @DesignPolice)
  • Adds label to bot creation radio group for a11y

Task Item

Fixes #2018 - a11y fix for creation flow dialog
Fixes: #2177 - Change template boxes to black text as stopgap

Screenshots

image

cwhitten and others added 30 commits March 18, 2020 11:28
* first commit of working prototype for mongoDB storage

* change mechanism for creating zip file for syncing to runtime
now builds all the files loaded into project (from arbitrary source) rahter than zipping a folder on disk

* clean up console output

* plugin loader looks for plugins, finds them

* dynamically load in the storage provider via plugin loader
use custom storage if one is specified

* remove some debug traces

* clean up some minor code formatting things

* disable linter rule to allow for requiring in plugin modules

* slight refactor of plugin loader to encapsulate functionality
add sample web route plugin
first tiny stab at publish -- TIME TO BRANCH

* functioning auth implementattion using passportjs

* sample github auth

* first round of changes for multi-user support
Related to microsoft#1918 and microsoft#1917

* add in the bot project id into the route

* fix new bot

* fix save as

* rationalize all the URLS used in context of a project

* plumb user identity down through storage

* disable plugins

* add readme

* plugin readme

* plugin readme

* plugin readme

* plugin readme

* import publisher controller from other branch

* update to readme

* import prototype of publishing page

* updates

* delete environment and connector

* add error checking for missing project by id

* Better error handling for attempts to write to a missing or moved project
Should fix last remaining item in microsoft#1918

* add publish method with  localpublish plugin

* keep bot dir clean

* basic publish of localpublish plugin

* remove hostBot

* add gitignore file

* change unzip template into copy template folder

* Fix build script

* Fix default projectMap not exists

* change luis operation to match local plugin

* polish default setting

* use projectId

* clean up

* remove lib dir

* use projectId

* use limit 'currentBotProjects' cache

* remove unused

* Update copy

* return error response when publish failed

* update name initialization process

* fix some test,hide publish tab and change deploy script

* fix UT integrity check

* fix bf-cli version error

* update the version

* remove @microsoft/bf-cli-command@1.0.0

* try to fix todo e2e test

* fix lint

* fix lint

* remove some unused test and skip some failed unit tests

* feat: Prevent old content from overwriting newer changes (microsoft#2156)

* updates to write operations to prevent overwrite
not 100% working on LU files yet

* debounce lu

* remove comment

* remove some console logs

* address feedback from chris

* remove commented code

* change hint word deploy to publish

* fix lint

* fix some test syntax

* update the ui for notification page

* fix luis publish path not found

* fix some e2e tests

* fix onboarding when using projectId

* fix notification page bug

* Back out simple overwrite protection, will replace with less error prone mechanism

* add plugins volumn in docker

* fix docker up

* fix unit test

* fix the filesetting path

* change docker to map multi ports. in order to support multi runtime

* add projectId when create and delete dialog

* fix botstatus

* fix botstatus

* remove console log

* fix settings files path

* update the moke data

Co-authored-by: Wenyi Luo <wenyluo@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: zhixzhan <zhixzhan@microsoft.com>
Co-authored-by: liweitian <liweitian93@outlook.com>
Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
)

* add cosmos db container template

* replace deprecated interface

Co-authored-by: Qi Kang <qika@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* a11y: remove extra Link stuff from settings Nav

* remove stray console.logs

Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* auto update data.json when schema updated

* fix lint

* add a version number and use generic migration to do re-init
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* replace IconButton with Icon

Replaces the IconButton in WidgetLabel.tsx with a plain Icon bearing an aria-label.

* fix unit tests

* Update WidgetLabel.tsx

Add a keyboard tab stop and adjust spacing - still not sure the SR experience is 100% great, but this at least makes it work.

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix issues 2193

* fix issue 2094 add heading

* add header in about page

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
… sync (microsoft#2173)

* move `useWindowDimensions` to separated file

* move `useLgTemplate` under hooks folder

* use `lgFiles` in shell store to compute lg text

* move useLgTemplate to 'hooks' folder

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…oft#2334)

* fix🐞(uischema): fix choices string
According to sdk.schema, the 'choices' field of 'Microsoft.ChoiceInput' could be either object list or string list. Make Visual Editor support both of those formats.
microsoft#2319

* fix🐞(uischema):dynamic choices
According to sdk definition, 'choices' could be an expression string.

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
In 'Microsoft.SetProperties', the 'value' field of an assignment could be either object or string. Stringify the value if it's an object.
microsoft#2309

Co-authored-by: Andy Brown <asbrown002@gmail.com>
I have added language parameter for generating the luconfig.json file to allow generation in another language. For example is-is.

Also I have added property control to make it 'es-us' by default

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* move FocusZone from NavItem to App

* Update index.tsx
* resolve issues in Notifications page

This addresses a few minor problems that were causing a11y issues.

* Update index.tsx

* Update index.js

Co-authored-by: Andy Brown <asbrown002@gmail.com>
…icrosoft#2331)

* Make menu show when hovering over dialog name and change js->ts

* update the interface

* update the naming
* lg/lu editor support warning message

* pass diagnostics to editor

* update

Co-authored-by: Andy Brown <asbrown002@gmail.com>
* reform bot file structure

* update

* update

* client add locale

* crud with locale

* update test sample bot

* update

* update emptybot structure

* update crud test

* auto fix lu referrence

* reform sample bot structure

* clean up

* update dialogId & isBot

* update

* update test

* redirect to root dialog

* update

* update test

* update test entry

* update tests

* handle old bot

* update sample

* update refer

* update

* update

* refer lg lu no locale

* import lg no locale

* update

* fix refer

* import resolve with locale

* set test locale

* get refered lu without locale

* Temporary disable SendConversationUpdate in CSharp test case, for sdk locale issue

* update test

* update test

* update test

* update test

* update

* update test

* use file resolver handle locale

* test

* resolve confilct

* reform test samplebot

* clean

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…ut cache management (microsoft#2176)

* clean affected parent node cache

* add UT for getParentPaths

* support batch change

* use trackActionListChange in CutSelection

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…t#2147)

* add arialabel and make lg/lu nav operable by keyboard

* update css

* yarn lint fix

* handle comments

* fix test case

* Update index.tsx

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…Is (microsoft#2208)

* init

* fix importResolver

* fix templates suggestions

* fix return

* fix get all templates method

* fix comments

* fix test cases

* upgrade lgParser related api

* fix

* revert designIds

* revert designIds

* upgrade lg api change

Co-authored-by: zhixzhan <zhixzhan@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* fix: can't find referred lu files for publish

* publish all the same id file
* add disk names

* add disk names

* remove console

* handle comments

* do not allow creating bot in path 'this PC'

* handle comments
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* when create bot, serialize entry dialog/lg/lu

* update test

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…2367)

* read action-header titles in SR

* add titleInHeader prop
a-b-r-o-w-n and others added 23 commits March 30, 2020 09:17
Fixes a regression by merging adaptive-form
bring in the release commit
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* add disk names

* add disk names

* remove console

* handle comments

* do not allow creating bot in path 'this PC'

* handle comments

* add directory permission checking

* rebase

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* add emit event ui plugin

* use emit event plugin in client

* make dropdown same width as menu

* turn on autoComplete

* add adaptive form to emit-event dependencies
)

* fix empty model error in luis build

* remove space

Co-authored-by: Qi Kang <qika@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
)

* fix bot status synchronization issue

* make loading error save in store

* polish error msg update

* remove console

* fix getStatus update

* fix comments

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
…microsoft#2445)

* fix a small typo

* fail to open OpenBot Pop up during the first time the app start
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
* refactor🦄(Visual Editor):'$type' to '$kind'

* update extension packages to use $kind

* update client to use $kind

* update server to use $kind

* update other packages to use $kind

* rename SDKTypes to SDKKinds

* update tests to use $kind

* update template bots to use $kind

Co-authored-by: Andy Brown <asbrown002@gmail.com>
…rosoft#2467)

* fix: remove duplicate entries in LgEditor list

* add fix for Lu too

* move changes to languages/*.ts
* fix issues rendering delete properties actions

* no longer recurse on schema

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* add callout label to Onboarding toggle

* add callout label to Onboarding toggle

* Update index.tsx

* add callout label to Onboarding toggle

* add callout label to Onboarding toggle

* Update index.tsx

* Update index.tsx

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet