a11y: focus move around composer, visual editor & form editor when click tab. #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten and
yeze322
as code owners
cwhitten
previously approved these changes
Apr 28, 2020
beyackle
suggested changes
Apr 28, 2020
There was a problem hiding this comment.
This looks good so far, but it isn't solving the original issue where keyboard focus will get stuck on the overall visual editor when there's a dialog displayed there. The image pasted here shows the black keyboard-focus rectangle on the visual editor; I got there by hitting Tab repeatedly, but now that it's there, no amount of Tab or Shift-Tab will move it.
The Narrator+Left/Right arrow keyboard commands do work while the screen-reader is active, but that's a separate issue.
Composer/packages/extensions/visual-designer/src/components/lib/KeyboardZone.tsx
Show resolved
Hide resolved
* master: (58 commits) fix: Copy skill manifests to the correct directory in the localPublish plugin (#2932) feat: Goto Begin Dialog after clicking dialog (#2922) fix: Improved Electron auto update UX (#2925) fix: Action Flow gradual left alignment (#2909) fix: word wrap in SendActivity (#2908) fix: Fixed various onboarding issues and updated content (#2900) chore: Component Governance (#2899) perf: improve property editor performance (#2921) fix: paste blank node (#2905) extract memory variables at lg lsp server (#2902) feat: manage samples via plugin (#2805) can not use event capture in visual editor (#2913) style: make focus styles more consistent (#2898) feat: azure publish plugin (#2733) fix: unable to clear form title (#2885) fix: Populate env variable with AppData folder (#2894) a11y: use Key/Value aria labels in object field (#2890) Fix border issue in visual editor (#2891) fix: changes manifest type from '.manifest' to '.json' (#2888) Fixed packaged folder structure. (#2887) ...
alanlong9278
requested review from
corinagum,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
approved these changes
May 7, 2020
cwhitten
approved these changes
May 9, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…ick tab. (microsoft#2785) * focus move * merge conflict Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
focus move around composer, visual editor & form editor when click tab.
Task Item
fix #2021
Screenshots