feat: package and schema update for 4.9.0-RC4 #2911
Conversation
luhan2017
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
carlosscastro,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
luhan2017
changed the title
|
@a-b-r-o-w-n In this latest schema, the BeginDialog.options is changed to "$ref": "#/definitions/objectExpression", which will affect the form ux like this: |
|
@luhan2017 why can't |
|
@luhan2017 @liweitian I believe I have updated everything needed, including the trigger creation modal. Please confirm. |
|
I've tested this and found some issues:
I' am wondering if there is anything wrong with my local environment, I will double check in my laptop soon. |
|
I will take a look ASAP. |
a-b-r-o-w-n
changed the title
|
@luhan2017 I have updated to the rc4 and updated the schema. There is currently an issue building the dotnet app though that maybe you can take a look at today. |
|
@luhan2017 I took a stab at correcting the build failure (due to microsoft/botbuilder-dotnet@08590f9) with the help of @lauren-mills |
…ecause it is no longer valid
|
I've tested all the templates, they all work well. so we are ready for review on this. |
| @@ -49,7 +49,7 @@ context('Notification Page', () => { | |||
| cy.findAllByText('__TestToDoBotWithLuisSample').should('exist'); | |||
| }); | |||
|
|
|||
| it('can show dialog expression error ', () => { | |||
| it.skip('can show dialog expression error ', () => { | |||
There was a problem hiding this comment.
Did you mean to leave this test skipped?
There was a problem hiding this comment.
Yes. Expression validation is broken currently. We decided not to block the PR and do a follow up bug fix.
| const types = Object.keys(schema.definitions).reduce((all, defName) => { | ||
|
|
||
| if (defName.startsWith('Microsoft.') && !defName.startsWith('Microsoft.Test')) { | ||
| all.push(defName); | ||
| } | ||
|
|
||
| return all; | ||
| }, []); |
There was a problem hiding this comment.
I won't block this PR on it, but I think this could be written more easily with a .filter.
There was a problem hiding this comment.
That's a good suggestion. Since this is already merged, I'll probably leave as is.
* package and schema update for 4.9-RC1 * update trigger wizard (microsoft#2917) * rename variable * update SDKKinds enum * fix references to removed kinds * fix schema resolution for property editor * do not title case the schema title * add ability to type custom event name in trigger creation * fix autoEndDialog type in samples * generate sdk enum with all definitions * Revert changes to ui schema and label map * update ActivityTemplate to IActivityTemplate for lg fields * resolve schema in order to determine stacking * remove test types from sdk enum * fix failing tests * skip failing test * update sdk packages and schema to rc4 * update bot start up to not use HostContext * Update some enum to lower case and removed the recognizerset sample because it is no longer valid * update deprecated method Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Description
Update sdk packages and schema for 4.9.0-RC1 which include following major changes:
Schema updates:
Runtime updates:
Task Item
fixes #2878
fixes #2942
Screenshots