chore: Update trigger wizard #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
liweitian
removed request for
cwhitten,
tonyanziano,
a-b-r-o-w-n,
boydc2014,
srinaath,
corinagum and
beyackle
a-b-r-o-w-n
reviewed
May 6, 2020
| @@ -42,7 +42,7 @@ export const intentTypeKey: string = SDKKinds.OnIntent; | |||
| export const activityTypeKey: string = SDKKinds.OnActivity; | |||
| export const messageTypeKey: string = SDKKinds.OnMessageEventActivity; | |||
| export const regexRecognizerKey: string = SDKKinds.RegexRecognizer; | |||
|
|
|||
| export const customerTypeKey: string = SDKKinds.OnCustomEvent; | |||
There was a problem hiding this comment.
Suggested change
| export const customerTypeKey: string = SDKKinds.OnCustomEvent; | |
| export const customEventTypeKey: string = SDKKinds.OnCustomEvent; |
| @@ -27,6 +27,7 @@ import { | |||
| intentTypeKey, | |||
| activityTypeKey, | |||
| messageTypeKey, | |||
| customerTypeKey, | |||
There was a problem hiding this comment.
Suggested change
| customerTypeKey, | |
| customEventTypeKey, |
| @@ -145,7 +146,11 @@ export const TriggerCreationModal: React.FC<TriggerCreationModalProps> = props = | |||
| }; | |||
|
|
|||
| const onSelectTriggerType = (e, option) => { | |||
| setFormData({ ...initialFormData, $kind: option.key }); | |||
| if (option.key === customerTypeKey) { | |||
There was a problem hiding this comment.
Suggested change
| if (option.key === customerTypeKey) { | |
| if (option.key === customEventTypeKey) { |
cwhitten
added a commit
that referenced
this pull request
May 8, 2020
* package and schema update for 4.9-RC1 * update trigger wizard (#2917) * rename variable * update SDKKinds enum * fix references to removed kinds * fix schema resolution for property editor * do not title case the schema title * add ability to type custom event name in trigger creation * fix autoEndDialog type in samples * generate sdk enum with all definitions * Revert changes to ui schema and label map * update ActivityTemplate to IActivityTemplate for lg fields * resolve schema in order to determine stacking * remove test types from sdk enum * fix failing tests * skip failing test * update sdk packages and schema to rc4 * update bot start up to not use HostContext * Update some enum to lower case and removed the recognizerset sample because it is no longer valid * update deprecated method Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* package and schema update for 4.9-RC1 * update trigger wizard (microsoft#2917) * rename variable * update SDKKinds enum * fix references to removed kinds * fix schema resolution for property editor * do not title case the schema title * add ability to type custom event name in trigger creation * fix autoEndDialog type in samples * generate sdk enum with all definitions * Revert changes to ui schema and label map * update ActivityTemplate to IActivityTemplate for lg fields * resolve schema in order to determine stacking * remove test types from sdk enum * fix failing tests * skip failing test * update sdk packages and schema to rc4 * update bot start up to not use HostContext * Update some enum to lower case and removed the recognizerset sample because it is no longer valid * update deprecated method Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update trigger wizard due to schema changed. Further modification may be needed.
Task Item