a11y: add labeled aria regions to pages #2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time without creating any new <div>s, which threw the layout off.
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
beyackle
changed the title
a-b-r-o-w-n
previously approved these changes
May 11, 2020
|
We're using Sentence cap across the product, right @zxyanliu ? |
|
@mareekuh I agree. It seems PVA and Azure both use sentence case for names such as a button or component. There might be some details like this to brush after this release. |
|
Looks like there's a merge conflict here anyway, so I can handle changing the labels to sentence-case as part of resolving that too. |
This time without creating any new <div>s, which threw the layout off.
…BotFramework-Composer into beyackle/ariaRegions2
|
This has diverged enough from master that rebasing and fixing conflicts is more difficult than manually reapplying the (relatively small set of) changes involved. Will close this one and reopen a new PR when that's up. |
|
See #3259 for the new version of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
role="region"and a bunch of ARIA labels to the app, letting SR users navigate around using landmarks. This time implemented without creating any new divs, which threw the layout off.Task Item
closes #2080
Screenshots
Just to demonstrate that the UI looks exactly like it did before:
