Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: add labeled aria regions to pages #3259

Merged
merged 5 commits into from
Jun 1, 2020
Merged

Conversation

beyackle
Copy link
Contributor

@beyackle beyackle commented Jun 1, 2020

Description

Adds role="region" and a bunch of ARIA labels to the app, letting SR users navigate around using landmarks.

Task Item

refs #2080

@beyackle
Copy link
Contributor Author

beyackle commented Jun 1, 2020

Note: this is a continuation of #2959, but it was easier to manually reapply the same changes instead of figuring out all of the merge conflicts.

@github-actions
Copy link

github-actions bot commented Jun 1, 2020

Coverage Status

Coverage remained the same at 41.69% when pulling 7e2935f on beyackle/ariaRegions3 into 16c10de on master.

@beyackle beyackle merged commit 7ade7ca into master Jun 1, 2020
@beyackle beyackle deleted the beyackle/ariaRegions3 branch June 1, 2020 23:03
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* add named regions to various pages

* finish adding regions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants