Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prime speech synthesis on microphone button click #2246

Merged
merged 7 commits into from
Aug 6, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jul 31, 2019

Fix #2245, fix #1514, fix #1515.

Changelog Entry

  • Fix #2245. Fix speech synthesis not working on Safari by priming the engine on the first microphone button click, by @compulim in PR #2246
  • Fix #1514. Added reference grammar ID when using Cognitive Services Speech Services, by @compulim in PR #2246
  • Fix #1515. Added dynamic phrases when using Cognitive Services Speech Services, by @compulim in PR #2246

Description

The AudioContext instance need to be primed by user gesture on Safari on iPad. Otherwise, audio clip playback will be paused indefinitely.

Also, dynamic phrases and reference grammar ID is added after bumping to latest web-speech-cognitive-services. Although dynamic phrases is supported, it is not used because currently, there are no fields in activity that provide suggestions or expected phrases.

Specific Changes

When the user click on the microphone button, we will prime the speech synthesis engine by sending an empty utterance.


  • Testing Added
  • Bump web-speech-cognitive-services, it is required for a persistent and prime-able AudioContext object, in their PR #36

@compulim compulim marked this pull request as ready for review August 1, 2019 09:35
@coveralls
Copy link

coveralls commented Aug 1, 2019

Coverage Status

Coverage increased (+0.1%) to 65.704% when pulling b530818 on compulim:fix-2245 into cac4cdb on microsoft:master.

@compulim
Copy link
Contributor Author

compulim commented Aug 5, 2019

Should bump to latest build and fix tests.

@compulim compulim merged commit 6532e53 into microsoft:master Aug 6, 2019
@compulim compulim deleted the fix-2245 branch August 6, 2019 02:06
@compulim compulim mentioned this pull request Oct 4, 2019
13 tasks
@compulim compulim mentioned this pull request Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speech: Fix Safari by priming AudioContext Speech: Biased word list Speech: Reference grammar ID for LUIS
3 participants