One single React package during development-time #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten and
tonyanziano
as code owners
compulim
changed the title
|
LGTM |
corinagum
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2261.
Changelog Entry
Breaking changes
reactandreact-domin our NPM package, instead, we will requires peer dependencies ofreact@^16.8.6andreact-dom@^16.8.6Changed
web-speech-cognitive-services@4.0.1-master.ad6e780, by @compulim in PR #2246 and PR #2274reactandreact-dom, in PR #2274/: Installreactandreact-domtodevDependenciesbundle: Movereactandreact-domfromdependenciestopeerDependenciescomponent: Removereactandreact-domfromdevDependenciesplayground: Removereactandreact-domfromdependenciessamples/*: Remove from Lerna and move to production version of Web ChatDescription
To use React hooks, both app and component must share the same reference of
reactandreact-dom. Details can be found in this article, https://reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react, under "Duplicate React".Since Web Chat is a mono-repo, we are using
npm link(throughlerna) during development. And this causes multiplereactto live in memory.On the other hand, we should not put
reactandreact-domas a production dependency ofbundle.Also, bumped
web-speech-cognitive-services, cleaned up a few unused dependencies, and fixed a speech problem in playground.Specific Changes
Please refer to
CHANGELOG.md, pretty comprehensive there. 😉Testing Added