Added more translations to Finnish localization #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiknaappila
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
|
|
|
Editing missing information. |
|
@sk91swd thanks for the contribution! More than happy to take a look at your PR once it's ready. When you reopen the PR, please also add your user/name to the LOCALIZATION.md and add a CHANGELOG.md entry. Thanks again! |
corinagum
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DirectLine does not show Finnish text in the chat window. I have tried to tackle this with custom code, but the simplest solution would be that DirectLine supports some basic Finnish text in the chat window (e.g. 'sending', 'new messages', 'x minutes ago'). I took a copy of the en-US.js file and translated it into Finnish. Some fields were already translated, good job.
Specific Changes
packages\component\src\Localization\fi-FI.js
-Added translations