-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Suggested Actions accessible again! #2613
Merged
corinagum
merged 14 commits into
microsoft:master
from
corinagum:1780-suggestedActionsA11y
Nov 20, 2019
Merged
Make Suggested Actions accessible again! #2613
corinagum
merged 14 commits into
microsoft:master
from
corinagum:1780-suggestedActionsA11y
Nov 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 1780-suggestedActionsA11y
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
tdurnford and
tonyanziano
as code owners
November 20, 2019 21:27
corinagum
changed the title
1780 suggested actions a11y
Make Suggested Actions Accessible again!
Nov 20, 2019
corinagum
changed the title
Make Suggested Actions Accessible again!
Make Suggested Actions accessible again!
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
compulim
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic approve if everything commented is fixed.
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(jk they were never accessible)
Fixes #1780
Fixes #2277
Fixes #2285
Changelog Entry
Note: How to test Suggested Actions container on Mock Bot
emptycard
orsuggested-actions
Description
aria-live=" "
andaria-hidden={true}
inside the Carousel componenten-us
for changes.Browser discrepancies
Previously, Suggested Actions were ignored by the AT. This PR fixes that, HOWEVER, there are some idiosyncrasies across browsers that are documented below: