Log and throw when oversized writer blows up

[eddyashton]

When these blow up, they might reach serialise() and crash a node. When we catch the exception we can't log the message in release builds, just in case they contain something private. But at the point where we throw, we know the contents aren't private (and are in fact likely to be useful, and unusual enough that they're worth reporting), so can log directly.

[ghost]

log_oversized_errors@76271 aka 20230921.40 vs main ewma over 20 builds from 75836 to 76264

Click to see table

main

build_id	build_number	Commit latency factor	ls_sgx_cft^	ls_sgx_cft_mem	pi_ls_sgx_cft^	pi_ls_sgx_cft_mem	pi_basic_sgx_cft^	pi_basic_sgx_cft_mem	pi_basic_js_sgx_cft^	pi_basic_js_sgx_cft_mem	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	pi_ls_jwt_sgx_cft^	pi_ls_jwt_sgx_cft_mem	ls_virtual_cft^	pi_basic_mt_virtual_cft^	pi_ls_virtual_cft^	pi_basic_virtual_cft^	ls_js_sgx_cft^	ls_js_sgx_cft_mem	pi_basic_js_virtual_cft^	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	ls_jwt_virtual_cft^	pi_ls_jwt_virtual_cft^	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	ls_js_virtual_cft^	ls_full_js_virtual_cft^	ls_js_jwt_virtual_cft^	hist_sgx_cft^	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^	pi_basic_mt_sgx_cft^	pi_basic_mt_sgx_cft_mem	tpcc_virtual_cft^	tpcc_sgx_cft^	tpcc_sgx_cft_mem
75836	20230915.2	0.806175	14058.9	1.67936e+07	14137	1.05021e+07	15692.2	1.46964e+07	1446.3	1.25993e+07	6865.75	1.88908e+07	6927.4	6.30784e+06	45882.2	71131.7	48155.9	55533.3	5761.62	1.67936e+07	4509.5	5745.27	1.67936e+07	17429.7	19296.8	4006.31	1.67936e+07	17117.5	14633.5	9896.12	41678	833529	1.17526e+06	8.15209e+06	3.07549e+07	28225.2	2.51822e+07	17210.5	5618.1	8.59996e+07
75842	20230915.5	0.812338	14057.6	1.67936e+07	14097.1	1.05021e+07	15647	1.46964e+07	1438.9	1.25993e+07	6863.63	1.67936e+07	6939.8	6.30784e+06	45522.7	66045.1	47870.5	54521.4	5785.28	1.67936e+07	4429.9	5782.56	1.67936e+07	17019.5	19290.9	4007.85	1.67936e+07	17063.7	14987.3	10237.6	41341.1	830832	1.18103e+06	8.1391e+06	3.03488e+07	27975.1	2.51822e+07	17070.3	5598.47	8.59996e+07
75882	20230915.14	0.79396	14070.2	1.88908e+07	14174.4	1.05021e+07	15653.1	1.46964e+07	1446.3	1.05021e+07	6863.13	1.88908e+07	7074	6.30784e+06	45745	82541.5	47701.7	54950.9	5781.81	1.67936e+07	4451.4	5780.46	1.67936e+07	17193.1	19974.4	4000.23	1.67936e+07	17175.9	14859.4	10059.6	41264.9	831777	1.18327e+06	8.17288e+06	3.10618e+07	27598.1	2.51822e+07	17347.4	5657.84	8.59996e+07
75891	20230915.17	0.812985	13993.8	1.67936e+07	14041.4	1.05021e+07	15427.5	1.46964e+07	1429.7	1.25993e+07	6863.77	1.88908e+07	7026.7	6.30784e+06	45795.3	81063.5	48452.4	54635	5820.89	1.67936e+07	4439.8	5489.42	1.67936e+07	17018.8	19367.8	3992.44	1.67936e+07	17619.6	14952.2	9842.66	40064.4	839722	1.17713e+06	8.17392e+06	3.07494e+07	27847.3	2.30851e+07	17178.3	5497.14	8.59996e+07
75905	20230915.21	0.794597	13971	1.88908e+07	14089.9	1.05021e+07	15562.1	1.46964e+07	1430.6	1.25993e+07	6840	1.88908e+07	6841	6.30784e+06	46018.7	84235.8	47955.2	55480.7	5780.32	1.67936e+07	4446.8	5754.13	1.67936e+07	17077.2	19101.1	3966.24	1.67936e+07	17045.6	16704.8	10411.6	39534.4	838322	1.18234e+06	8.14897e+06	3.10045e+07	28013	2.51822e+07	17245	5560.01	8.59996e+07
75919	20230918.1	0.807726	14069.4	1.88908e+07	14100.3	1.05021e+07	15624.7	1.46964e+07	1447.6	1.25993e+07	7246.59	1.67936e+07	6938.6	6.30784e+06	45705.8	80251.8	48106.5	54799.3	5817.38	1.67936e+07	4473.2	5750.83	1.88908e+07	17309.5	19191.3	4001.82	1.67936e+07	17711.8	15013	9870.13	45085.8	836473	1.18406e+06	8.15462e+06	3.0718e+07	28037.7	2.51822e+07	17123.9	5617.99	8.59996e+07
75972	20230919.3	0.797908	13979.5	1.88908e+07	14131.3	1.05021e+07	15590.4	1.46964e+07	1440.2	1.25993e+07	6847.99	1.88908e+07	7025.4	6.30784e+06	45907.5	89712	48087.1	54724	5812.09	1.67936e+07	4440.1	5786.4	1.67936e+07	17023.5	19581.7	3974.68	1.67936e+07	17397.5	14717.5	10069	46322.7	826226	1.18058e+06	8.15186e+06	3.07355e+07	28013.6	2.51822e+07	17443	5600.61	8.59996e+07
75984	20230919.8	0.791942	14054.7	1.88908e+07	14107	1.05021e+07	15616.2	1.46964e+07	1440.3	1.25993e+07	6841.78	1.67936e+07	7001.6	6.30784e+06	45556.3	73482.4	48588.5	54594.9	5811.6	1.67936e+07	4378.8	5785.63	1.67936e+07	17238.5	19201.2	3995.74	1.67936e+07	14682.5	15000.4	9880.77	43684.1	821876	1.17893e+06	8.13315e+06	3.27115e+07	27995.4	2.51822e+07	17353.2	5656.14	8.59996e+07
76003	20230919.15	0.823869	14103.4	1.88908e+07	14168.3	1.05021e+07	15708.5	1.46964e+07	1456	1.25993e+07	6930.48	1.88908e+07	7095.2	6.30784e+06	45430.7	78893.3	48253.5	54962.6	5821.17	1.67936e+07	4451	5749.41	1.67936e+07	17315.5	19169.9	3996.53	1.67936e+07	17304	15065.9	9861.45	45003	836289	1.18821e+06	8.14084e+06	3.21795e+07	28110.3	2.51822e+07	17296.1	5596.5	8.59996e+07
76015	20230919.19	0.780865	13933.9	1.67936e+07	14063	1.05021e+07	15454.5	1.25993e+07	1445.3	1.25993e+07	6833.42	1.88908e+07	6956.1	6.30784e+06	45884.9	68481.1	48693.3	55353.3	5764.29	1.67936e+07	4451.1	5741.3	1.67936e+07	17089.2	19693.2	3973.09	1.67936e+07	17055.5	14594.9	9802.74	43090.7	828277	1.17503e+06	8.16854e+06	3.05736e+07	28252.3	2.30851e+07	17179.4	5582.98	8.80968e+07
76054	20230919.37	0.767755	14039.8	1.88908e+07	14151.3	1.05021e+07	15693.4	1.25993e+07	1444.8	1.25993e+07	7221.43	1.67936e+07	7058.5	6.30784e+06	43642.1	84164.5	48127.4	51879.1	5780.5	1.67936e+07	4461.4	5743.01	1.67936e+07	17346.6	19026.2	4003.19	1.67936e+07	17520.1	14884.1	10064.1	39087.4	834363	1.18202e+06	8.13722e+06	3.07706e+07	27635.8	2.30851e+07	17131.7	5608.14	8.59996e+07
76076	20230919.46	0.841856	13972.3	1.88908e+07	14006.2	1.05021e+07	15504.1	1.46964e+07	1431.1	1.25993e+07	6868.27	1.88908e+07	6991	6.30784e+06	45544.3	78567.6	47874.6	53078.7	5792.24	1.67936e+07	4492.4	5488.53	1.67936e+07	17214.5	16564.8	3984.22	1.67936e+07	17135.5	14642.9	9786.58	44362.7	835522	1.18649e+06	8.15306e+06	3.0439e+07	27742.6	2.51822e+07	17381.2	5535.46	8.59996e+07
76097	20230920.1	0.771017	14031.1	1.67936e+07	14131.3	1.05021e+07	15471.1	1.46964e+07	1446.5	1.25993e+07	6850.31	1.67936e+07	6988.2	6.30784e+06	45477.1	86385.1	48221.6	55062.5	5784.34	1.67936e+07	4480.6	5750.9	1.67936e+07	17201.5	19641.3	3973.75	1.67936e+07	17217	14623.7	9757.69	36337.8	833307	1.18308e+06	8.15264e+06	3.09295e+07	28027	2.30851e+07	17317	5650.74	8.59996e+07
76165	20230921.3	0.768436	14067.6	1.67936e+07	14121.5	1.05021e+07	15674.5	1.25993e+07	1441.9	1.25993e+07	6846.38	1.67936e+07	7088.4	6.30784e+06	45677.4	77456.4	48197.9	55130.8	5774.38	1.67936e+07	4354.8	5777.07	1.67936e+07	17117.4	19846	3994.62	1.67936e+07	17049.8	16843.7	9885.87	45264.8	841894	1.18293e+06	8.17154e+06	3.14395e+07	27623	2.30851e+07	17168.2	5585.9	8.59996e+07
76171	20230921.6	0.835403	14063.7	1.88908e+07	14139.1	1.05021e+07	15638.1	1.46964e+07	1438.5	1.25993e+07	7263.82	1.67936e+07	6934.8	6.30784e+06	45885	90391.4	49813.7	55693	5777.83	1.67936e+07	4397.5	5739.47	1.67936e+07	17248.2	19556.1	3979.61	1.67936e+07	17048.7	14393.6	9900.28	47592.5	835535	1.18048e+06	8.14991e+06	3.10731e+07	28181.5	2.51822e+07	17444	5590.06	8.59996e+07
76203	20230921.17	0.786125	14046.3	1.88908e+07	14136.2	1.05021e+07	15702.1	1.25993e+07	1451.3	1.25993e+07	7265.93	1.67936e+07	6938.8	6.30784e+06	45471.5	91230.3	48425.7	55265.4	5812.78	1.67936e+07	4445	5731.91	1.88908e+07	17069.4	19840.5	4003.75	1.67936e+07	17208.3	16828.2	9850.06	41833.5	828314	1.18182e+06	8.15189e+06	3.14873e+07	28117.4	2.51822e+07	17331.8	5590.41	8.59996e+07
76211	20230921.19	0.768321	13915.4	1.88908e+07	14037.6	1.05021e+07	15443.2	1.46964e+07	1427	1.25993e+07	7200.01	1.88908e+07	6829.3	6.30784e+06	45812.6	83281	48471.5	54793.9	5793.08	1.67936e+07	4423.3	5714.67	1.88908e+07	16980.2	19036	4002.62	1.67936e+07	17505.3	14920.8	10061.9	42595.5	836057	1.18019e+06	8.15267e+06	3.07739e+07	28190	2.51822e+07	17227.8	5540.05	8.59996e+07
76229	20230921.26	0.829414	14090.4	1.67936e+07	14190.5	1.05021e+07	15600	1.46964e+07	1447.9	1.25993e+07	7298.28	1.67936e+07	6978.2	6.30784e+06	43704.7	66135.4	47600.2	53570.9	5830.7	1.67936e+07	4439.6	5721.21	1.67936e+07	16987.8	19431.4	4004.1	1.67936e+07	17595.1	14848.4	10010.4	42758.2	832626	1.17831e+06	8.13609e+06	3.08452e+07	28059.6	2.51822e+07	17401.8	5652.51	8.59996e+07
76246	20230921.32	0.813443	13924	1.88908e+07	14031.5	1.05021e+07	15320.5	1.46964e+07	1428.1	1.25993e+07	6841.82	1.67936e+07	6915.5	6.30784e+06	46143	90083.2	48647.1	55120.7	5775.95	1.67936e+07	4455	5741.57	1.88908e+07	17322	19312.1	4016.26	1.67936e+07	16895.7	14660.4	9783.22	44774.6	836067	1.18217e+06	8.15348e+06	3.24647e+07	28040.6	2.51822e+07	17276.3	5560.83	8.59996e+07
76264	20230921.38	0.780894	13944.9	1.67936e+07	14014.4	1.05021e+07	15418.7	1.46964e+07	1429.9	1.25993e+07	6816.34	1.88908e+07	6879.8	6.30784e+06	45759.3	77135.1	46429.6	54858.2	5792	1.67936e+07	4451.4	5484.27	1.88908e+07	17199.9	19967.7	3997.38	1.67936e+07	17029.2	15131.4	9808.43	44676.9	836500	1.18323e+06	8.15426e+06	3.14101e+07	28078	2.30851e+07	17230	5498.22	8.59996e+07

log_oversized_errors

build_id	build_number	pi_basic_mt_sgx_cft^	pi_basic_mt_sgx_cft_mem	Commit latency factor	tpcc_sgx_cft^	tpcc_sgx_cft_mem	tpcc_virtual_cft^	ls_sgx_cft^	ls_sgx_cft_mem	pi_ls_sgx_cft^	pi_ls_sgx_cft_mem	ls_virtual_cft^	pi_basic_sgx_cft^	pi_basic_sgx_cft_mem	pi_ls_virtual_cft^	pi_basic_virtual_cft^	pi_basic_js_virtual_cft^	ls_jwt_virtual_cft^	pi_basic_mt_virtual_cft^	pi_ls_jwt_virtual_cft^	pi_basic_js_sgx_cft^	pi_basic_js_sgx_cft_mem	ls_js_virtual_cft^	ls_full_js_virtual_cft^	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	ls_js_jwt_virtual_cft^	pi_ls_jwt_sgx_cft^	pi_ls_jwt_sgx_cft_mem	ls_js_sgx_cft^	ls_js_sgx_cft_mem	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	hist_sgx_cft^	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^
76241	20230921.30	27850.3	2.30851e+07	0.790561	5615.05	8.59996e+07	17304.2	14065.9	1.88908e+07	14114.9	1.05021e+07	45773.5	15579	1.46964e+07	48355.2	54360.6	4422	17292.5	72881.6	19958.5	1443.8	1.25993e+07	17335.2	16775	6825.71	1.67936e+07	9821.51	6895	6.30784e+06	5773.6	1.67936e+07	5775.12	1.67936e+07	3973.8	1.67936e+07	40259.4	838938	1.17905e+06	8.1554e+06	3.06477e+07
76260	20230921.36	27836.9	2.30851e+07	0.780794	5648.22	8.59996e+07	17246.3	14073	1.88908e+07	14111.4	1.05021e+07	45595.7	15694.6	1.25993e+07	48454.3	55156.2	4503.2	17416.6	75065.3	19285.7	1442.8	1.25993e+07	16965.7	14653.9	6847.63	1.88908e+07	9816.62	6964.9	6.30784e+06	5807.27	1.67936e+07	5752.14	1.88908e+07	3974.79	1.67936e+07	45358.9	829956	1.17939e+06	8.15225e+06	3.2013e+07
76271	20230921.40	28000.7	2.30851e+07	0.804667	5652.54	8.59996e+07	17359.3	14059.4	1.88908e+07	14201.2	1.05021e+07	45529.4	15681.5	1.46964e+07	48356.6	55048.3	4444	17223.1	72347.6	19698.6	1438	1.25993e+07	17353.5	14957.3	7246.45	1.67936e+07	9916.39	7030.5	6.30784e+06	5812.99	1.67936e+07	5765.08	1.67936e+07	3992.5	1.67936e+07	42231.4	832749	1.17403e+06	8.15488e+06	3.1191e+07