Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/4.x] Cherry pick: Log and throw when oversized writer blows up (#5673) #5677

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2023

Backports the following commits to release/4.x:

@ghost ghost self-requested a review September 21, 2023 18:03
@ghost ghost assigned eddyashton Sep 21, 2023
@ghost ghost added the 4.x-backport Highlights PRs targeting the 4.x branch label Sep 21, 2023
@ghost
Copy link
Author

ghost commented Sep 21, 2023

backport/release/4.x/pr-5673@76280 aka 20230921.43 vs release/4.x ewma over 19 builds from 74804 to 76166

Click to see table

release/4.x

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem tpcc_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
74804 20230822.3 0.796514 7265.47 8.59996e+07 19799.4 1.88908e+07 20117.6 1.25993e+07 6692.61 1.67936e+07 17136.5 6506 6.30784e+06 43758.1 46881.6 12389 12930.5 1711.18 1.05021e+07 4460.15 3735.81 1504.79 1.05021e+07 3292.63 1405.88 1.05021e+07 48039.5 829164 1.17458e+06 8.1748e+06 3.07323e+07
74885 20230823.4 0.787354 7316.88 8.59996e+07 19870.8 1.88908e+07 20030.1 1.25993e+07 9923.09 1.88908e+07 17174.1 9991.3 6.30784e+06 45558.5 46893.1 17406.4 18997.7 1710.54 1.05021e+07 4358.03 3705.83 1490.79 1.05021e+07 3669.26 1563.88 1.05021e+07 48043.1 831686 1.18028e+06 8.15264e+06 3.08592e+07
74940 20230824.3 0.78863 7261.66 8.39025e+07 19750.8 1.88908e+07 16863.1 1.05021e+07 9026.95 1.88908e+07 17143.9 10321.5 6.30784e+06 45734.9 46799.4 17247.6 18623 1707.63 1.05021e+07 4346.35 3764.21 1493.33 1.05021e+07 3598.76 1567.02 1.05021e+07 46610.2 821315 1.18158e+06 8.15218e+06 3.05822e+07
74973 20230825.2 0.791756 7328.94 8.59996e+07 19883.1 1.88908e+07 20130 1.25993e+07 9920.56 1.88908e+07 17442.9 10330.6 6.30784e+06 45892.8 47452.1 17309.8 19442.4 1711.77 1.05021e+07 4274.09 3711.69 1492.13 1.05021e+07 3626.43 1564.25 1.05021e+07 50756.4 836271 1.18102e+06 8.15205e+06 3.08969e+07
75003 20230828.3 0.787123 7317.51 8.59996e+07 19800.3 1.88908e+07 20220.9 1.25993e+07 10004.8 1.88908e+07 17670.1 9973.6 6.30784e+06 43906.5 47174 17399.9 19062.5 1707.4 1.05021e+07 4345.17 3749.43 1505.32 1.05021e+07 3625.57 1556.44 1.05021e+07 41973.1 827983 1.17738e+06 8.14972e+06 3.01807e+07
75017 20230829.1 0.771679 7300.34 8.39025e+07 19813.5 1.88908e+07 20124.5 1.25993e+07 9932.42 1.88908e+07 17308.5 10006.3 6.30784e+06 45692 47755.7 17200.9 19325.1 1718.05 1.05021e+07 4325.97 3693.58 1495.86 1.05021e+07 3791.01 1544.6 1.05021e+07 48701.1 831261 1.18008e+06 8.13609e+06 3.08885e+07
75076 20230830.3 0.785307 7283.3 8.39025e+07 19879.2 1.88908e+07 20200.5 1.25993e+07 9943.71 1.88908e+07 17282.5 9995.4 6.30784e+06 45686.8 47531.7 17700.3 19257.8 1708.16 1.05021e+07 4348.93 3713.29 1505.93 1.05021e+07 3666.91 1560.67 1.05021e+07 46216.7 826647 1.17615e+06 8.1552e+06 3.11365e+07
75141 20230831.3 0.781168 7369.4 8.59996e+07 19885.7 1.88908e+07 20121.9 1.25993e+07 9930.84 1.88908e+07 17106.2 10009.2 6.30784e+06 45589.1 47632.4 17317.4 19099.2 1714.27 1.05021e+07 4343.94 3715.1 1496.41 1.05021e+07 3780.54 1560.29 1.05021e+07 45870.5 831035 1.18071e+06 8.15481e+06 3.08104e+07
75183 20230901.3 0.794042 7346.61 8.59996e+07 19934.6 1.88908e+07 20188.6 1.25993e+07 9943.91 1.88908e+07 17437.3 9998.3 6.30784e+06 45651.6 47636.1 17322.4 19019.7 1711.07 1.05021e+07 4327.54 3594.23 1501.16 1.05021e+07 3627.3 1563.8 1.05021e+07 43646 831108 1.18468e+06 8.15361e+06 3.2284e+07
75256 20230904.3 0.807766 7373.31 8.59996e+07 19853.3 1.88908e+07 20128.3 1.25993e+07 9931.13 1.88908e+07 17071.6 9973.8 6.30784e+06 45793.3 47404.1 17444 19279.7 1709.74 1.05021e+07 4404.47 3729.76 1488.27 1.05021e+07 3646.84 1564.92 1.05021e+07 50296.9 822591 1.17744e+06 8.14923e+06 3.07097e+07
75301 20230905.2 0.756588 7352.76 8.59996e+07 19874.9 1.88908e+07 20086.9 1.25993e+07 9937.23 1.88908e+07 17108.9 9999 6.30784e+06 45924.9 47575.8 17207.3 19342.8 1710.02 1.05021e+07 4384.42 3734.13 1492.67 1.05021e+07 3813.72 1562.74 1.05021e+07 46111.6 829476 1.17788e+06 8.1539e+06 3.05339e+07
75434 20230906.3 0.814451 7317.57 8.59996e+07 19846.3 1.88908e+07 20089.9 1.25993e+07 9918.2 1.88908e+07 17388.8 10019.6 6.30784e+06 45567.3 46757.2 17538 19090.2 1707.05 1.05021e+07 4366.19 3693.47 1505.03 1.05021e+07 3654.26 1555.82 1.05021e+07 44194.8 832702 1.17824e+06 8.1527e+06 3.06688e+07
75523 20230907.4 0.809625 7305.32 8.59996e+07 19981.1 1.88908e+07 20356.7 1.25993e+07 9940.27 1.88908e+07 17085.1 10027.6 6.30784e+06 45751.9 46749.3 17197.5 19443.8 1711.21 1.05021e+07 4330.79 3660.43 1505.29 1.05021e+07 3685.06 1556.28 1.05021e+07 50318 829169 1.1722e+06 8.17385e+06 3.09048e+07
75583 20230908.4 0.799341 7325.75 8.39025e+07 19998.3 1.88908e+07 20305.3 1.25993e+07 9950.01 1.88908e+07 17095 10009.2 6.30784e+06 43717.1 46017.2 17739.7 19324 1712.49 1.05021e+07 4234.92 3708.28 1492.19 1.05021e+07 3624.39 1562.08 1.05021e+07 48273.6 832160 1.18457e+06 8.15296e+06 3.05694e+07
75665 20230911.3 0.770816 7288.09 8.59996e+07 20041.2 1.88908e+07 20354.1 1.05021e+07 9908.42 1.88908e+07 17376.4 9988.9 6.30784e+06 45885.5 46324.2 17551.7 18779 1712.89 1.05021e+07 4457.96 3739.96 1507.17 1.05021e+07 3648.03 1560.02 1.05021e+07 43436.1 834564 1.18809e+06 8.17186e+06 3.06931e+07
75920 20230918.2 0.768212 5579.84 8.59996e+07 14048.7 1.67936e+07 14271.7 1.05021e+07 6852 1.88908e+07 17415.6 7202.3 6.30784e+06 45796 47074.5 17426.5 18950.5 1462.07 1.05021e+07 4433.53 3715.41 1283.26 1.05021e+07 3628.69 1291.67 1.05021e+07 47215.3 833402 1.18448e+06 8.15176e+06 3.1067e+07
75974 20230919.4 0.764615 5607.33 8.59996e+07 14144.9 1.88908e+07 14282.2 1.05021e+07 7307.34 1.67936e+07 17068.4 7254.6 6.30784e+06 45515.7 47206.4 17035.4 17228.9 1464.14 1.05021e+07 4403.8 3649.78 1290.05 1.05021e+07 3737.33 1300.19 1.05021e+07 47582.6 832991 1.17769e+06 8.15416e+06 3.07134e+07
76099 20230920.3 0.769422 5659.06 8.59996e+07 14114.6 1.88908e+07 14259.7 1.05021e+07 6818.42 1.88908e+07 17448.2 7040.6 6.30784e+06 45650 47597.3 16959.6 18965.6 1462.46 1.05021e+07 4438.6 3745.31 1281.88 1.05021e+07 3796.36 1303.32 1.05021e+07 45383.9 834668 1.1819e+06 8.15507e+06 3.07535e+07
76166 20230921.4 0.813695 5615.09 8.59996e+07 14082.6 1.88908e+07 14266.1 1.05021e+07 6868.35 1.67936e+07 17169.6 7201.7 6.30784e+06 45733.3 47828.6 17192.7 18659.5 1463.7 1.05021e+07 4396.97 3744.51 1266.47 1.05021e+07 3768.92 1291.86 1.05021e+07 45721.1 838024 1.18114e+06 8.15316e+06 3.07434e+07

backport/release/4.x/pr-5673

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem tpcc_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
76280 20230921.43 0.777102 5581.05 8.59996e+07 14066.7 1.88908e+07 14192.9 1.05021e+07 6864.64 1.88908e+07 17108.9 7209.3 6.30784e+06 43671.1 44773.4 17248.2 18429.4 1458.89 1.05021e+07 4306.15 3666.69 1265.48 1.05021e+07 3671.68 1304.02 1.05021e+07 44770.3 837516 1.17945e+06 8.17235e+06 3.12586e+07

images

@achamayou achamayou merged commit 289c2b7 into release/4.x Sep 22, 2023
16 checks passed
@achamayou achamayou deleted the backport/release/4.x/pr-5673 branch September 22, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x-backport Highlights PRs targeting the 4.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants