Add CLI argument for SNP context directory #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
added
auto-backport
eddyashton
changed the title
|
sec_ctxt_dir_env_var_cli@76430 aka 20230926.7 vs main ewma over 20 builds from 76076 to 76422 Click to see tablemain
sec_ctxt_dir_env_var_cli
|
achamayou
reviewed
Sep 25, 2023
achamayou
reviewed
Sep 25, 2023
achamayou
approved these changes
Sep 25, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This was referenced Sep 28, 2023
ghost
mentioned this pull request
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit a5f3b4c) # Conflicts: # CHANGELOG.md # doc/operations/platforms/snp.rst # tests/infra/remote.py
eddyashton
added
the
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5384.
Deprecates config field
attestation.security_context_directory, replaces with CLI--snp-security-context-dir-var. Includes default valueUVM_SECURITY_CONTEXT_DIR, so this should never be a required arg.Also reshuffled which fields of the config are required - I thought that with the previous PR (#5665) we no longer needed the
.enclaveconfig entry at all, but in fact thetypeandplatformfields are required (always used), so I've updated the schema to require them.