Only enable JS runtime limits during execution #5730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
only_enable_runtime_limits_during_js_exec@77292 aka 20231016.22 vs main ewma over 20 builds from 76888 to 77284 Click to see tablemain
only_enable_runtime_limits_during_js_exec
|
eddyashton
reviewed
Oct 16, 2023
eddyashton
approved these changes
Oct 16, 2023
…ithub.com/achamayou/CCF into only_enable_runtime_limits_during_js_exec
…ithub.com/achamayou/CCF into only_enable_runtime_limits_during_js_exec
achamayou
added
auto-backport
eddyashton
reviewed
Oct 16, 2023
eddyashton
reviewed
Oct 16, 2023
eddyashton
approved these changes
Oct 16, 2023
achamayou
commented
Oct 16, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
ghost
mentioned this pull request
achamayou
added a commit
to achamayou/CCF
that referenced
this pull request
Oct 24, 2023
(cherry picked from commit c2f42d4) # Conflicts: # .daily_canary # CHANGELOG.md # src/js/wrap.cpp # tests/js-custom-authorization/custom_authorization.py
achamayou
added a commit
to achamayou/CCF
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit c2f42d4) # Conflicts: # CHANGELOG.md # src/js/wrap.cpp
achamayou
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #5729 in addressing #5589. Also fixes #5731.
This change removes the interpreter heap, stack and runtime caps outside of JS code execution, which avoids having to handle those situations in the preparation of the runtime and of the response. In those contexts, the limits set by the environment (OS and/or SGX) apply instead, as they do in the rest of the code.
Note that this of course does not solve the issue of leaks in case a C++ exception is thrown in a wrapped function called from JS, this will need separate changes.
Also changed runtime options setting so that governance always has at least the default values available, to avoid getting to an unrecoverable situation where the values are so low that no further governance is possible.