JS FFI exception safety update #5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
js_ffi_exception_safety@77629 aka 20231023.31 vs main ewma over 20 builds from 76994 to 77584 Click to see tablemain
js_ffi_exception_safety
|
eddyashton
reviewed
Oct 19, 2023
…u/CCF into js_ffi_exception_safety
eddyashton
reviewed
Oct 23, 2023
eddyashton
approved these changes
Oct 23, 2023
achamayou
added
auto-backport
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
achamayou
added a commit
to achamayou/CCF
that referenced
this pull request
Oct 26, 2023
(cherry picked from commit c08a8c5)
achamayou
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5589.
I have now done a first pass on all the calls listed in the issue. There is still scope for cleanup, in particular in governance code where we don't use safe wrappers as extensively as we should. I've already removed some unused wrappers, but I'm still finding some.
I've had a look at removing the JSValue& conversion on the WrappedValue, but it's massive amount of further changes, and it's not necessary to fix the leak, so I think I would like to go ahead with this and unblock #5740.
Another thing that I've put in a pin in for now is that the crypto code (ie. wrappers for OpenSSL) mostly (but not exclusively) throws std::runtime_error to indicate validation failures, and std::logic_error is used for more internal failures. It's important to distinguish them when we validate an x509 chain for example, with some fuzziness. If one of the values in the chain is not a valid PEM for example, is that False or exception (I think it's exception, but it's arguable). Filed as #5760.