Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service cert subject name is configurable #5993

Merged

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Feb 6, 2024

Allow configuration of the service certificate subject name at network start:

"service_subject_name": {
  "type": "string",
  "default": "CN=CCF Service",
  "description": "Subject name to include in service certificate"
},

Changing subject names during the lifetime of a service would impact the verification of service endorsements on historical receipts. This is because CCF sets CA & pathlen 0 on all endorsements, and while this constraint is considered met by OpenSSL when the subject_name values of historical identities match (with different public keys), it is not when they differ.

As a result, and to maintain consistent endorsement constraints, new ledgers can only set the subject_name of the service certificate once. We may revisit this in the future if necessary.

@ghost
Copy link

ghost commented Feb 6, 2024

service_cert_subject_name_is_configurable@82794 aka 20240318.23 vs main ewma over 20 builds from 82441 to 82788

Click to see table

main

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem pi_basic_mt_virtual_cft^ tpcc_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ hist_sgx_cft^ ls_js_jwt_virtual_cft^ KV ser (/s)^ KV deser (/s)^ KV snap ser (/s)^ KV snap deser (/s)^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
82441 20240311.1 0.818209 5572.44 8.59996e+07 13983.1 1.88908e+07 28099.2 2.30851e+07 13370.1 1.05021e+07 15453.9 1.25993e+07 1358.8 1.25993e+07 6870.14 1.88908e+07 7077.5 6.30784e+06 5790.64 1.67936e+07 96888.6 17288.1 5456.74 1.67936e+07 53367.8 56506.8 62100.9 3985.54 1.67936e+07 4417.4 20803.9 21587.1 17464.1 17137.7 45635 11747.7 1.03584e+06 1.16374e+06 7514.24 1398.31 828598 1.18512e+06 8.153e+06 3.02507e+07 38449 376
82456 20240311.7 0.839718 5496.55 8.59996e+07 13992.5 1.67936e+07 28204.3 2.30851e+07 14138.2 1.05021e+07 15452.5 1.25993e+07 1359.7 1.25993e+07 7197.94 1.67936e+07 6906.8 6.30784e+06 5798.3 1.67936e+07 75238.8 17270.2 5445.48 1.67936e+07 52929.5 40908.3 62552.9 3987.39 1.67936e+07 4445.4 20602.8 22072.1 17369.4 17229.3 40420.9 11525.8 1.0003e+06 1.1489e+06 7738.78 1400.32 835081 1.17571e+06 8.12998e+06 3.11379e+07 39343 379
82473 20240312.1 0.805266 5587.27 8.59996e+07 13996.9 1.88908e+07 27888.1 2.51822e+07 14196.5 1.05021e+07 15567.6 1.46964e+07 1368.9 1.25993e+07 6854.5 1.67936e+07 7000.1 6.30784e+06 5790.57 1.67936e+07 94835.1 17246.9 5461.32 1.67936e+07 52699.4 56658.8 62660.2 3996.37 1.67936e+07 4303.5 21030.7 21444.5 17406.2 17509.8 45755.4 11603.4 1.0445e+06 1.14247e+06 7854 1405.81 834082 1.17499e+06 8.15056e+06 3.06353e+07 39294 382
82502 20240312.11 0.829827 5635.38 8.59996e+07 14074.4 1.67936e+07 28411.5 2.30851e+07 14154 1.05021e+07 15695 1.25993e+07 1377.7 1.25993e+07 7212.08 1.67936e+07 7045.2 6.30784e+06 5796.65 1.67936e+07 67917.8 17181.6 5481.05 1.67936e+07 52840.8 56306.6 60613.1 3993.69 1.67936e+07 4403.8 20810.3 21757.1 17364.2 17169.1 42603.8 11736.7 1.02249e+06 1.11421e+06 8295.97 1399.08 834662 1.17789e+06 8.15008e+06 3.1622e+07 40629 382
82521 20240313.2 0.802259 5630.28 8.59996e+07 14016.3 1.67936e+07 28015.2 2.30851e+07 14157.1 1.05021e+07 15625.3 1.46964e+07 1370.8 1.25993e+07 7221.85 1.67936e+07 6967.1 6.30784e+06 5805.73 1.67936e+07 76117 17221.6 5440.36 1.67936e+07 52968.6 55930.6 61014 4000.28 1.67936e+07 4425.8 21086.2 21616.5 17381.5 17146.1 43377.2 11718.2 1.0381e+06 1.07747e+06 7780.75 1400.44 830900 1.1784e+06 8.13131e+06 3.11691e+07 40274 372
82561 20240313.15 0.826024 5556.37 8.59996e+07 13920.3 1.88908e+07 28184.8 2.51822e+07 14042.1 1.05021e+07 15390.3 1.46964e+07 1354.4 1.25993e+07 6798.93 1.88908e+07 6821.4 6.30784e+06 5783.72 1.67936e+07 87765.6 17277.8 5479.15 1.67936e+07 53059.5 56330.7 62396.4 3970.22 1.67936e+07 4435.2 20981.1 21688.2 20773 17387.5 43173.6 11678.1 1.0686e+06 1.16496e+06 7967.99 1398.97 831057 1.17861e+06 8.15024e+06 3.06293e+07 38781 371
82592 20240314.2 0.803179 5591.23 8.59996e+07 13986.3 1.88908e+07 28159 2.30851e+07 14075.3 1.05021e+07 15603.2 1.25993e+07 1368 1.25993e+07 6825.51 1.88908e+07 6927.3 6.30784e+06 5791.99 1.67936e+07 89283.3 17520.4 5445.85 1.67936e+07 53231.3 56074.6 60237.6 3996.47 1.67936e+07 4376.3 20914.1 22366.9 17567.3 17621.7 46713 11732.7 1.05496e+06 1.15902e+06 7953.59 1402.1 817299 1.18123e+06 8.12576e+06 3.11341e+07 38555 373
82609 20240314.9 0.842778 5524.91 8.59996e+07 14014.6 1.67936e+07 28014.3 2.30851e+07 14135.5 1.05021e+07 15615.2 1.46964e+07 1366.1 1.25993e+07 6842.49 1.67936e+07 7080.4 6.30784e+06 5793.47 1.67936e+07 85734 17523.4 5469.72 1.67936e+07 53248.3 56867.9 63565.8 3976.63 1.67936e+07 4425.6 20628.4 22031.3 17455.4 17418.7 47474.2 11703 1.00746e+06 1.08319e+06 8424.96 1404.01 833654 1.18237e+06 8.16864e+06 3.02101e+07 38112 381
82620 20240314.12 0.821359 5600 8.59996e+07 14034.6 1.88908e+07 28220.4 2.51822e+07 14133 1.05021e+07 15635.1 1.25993e+07 1369.7 1.25993e+07 6906.12 1.88908e+07 7082.2 6.30784e+06 5794.44 1.67936e+07 79508.6 17148.3 5462.66 1.67936e+07 53103.1 56239.8 62026.5 3985.85 1.67936e+07 4421 21105.2 22200.5 17605.9 17370.4 47389.9 11726.6 1.0269e+06 1.19674e+06 8035.91 1400 835100 1.18237e+06 8.13644e+06 3.07632e+07 39491 379
82628 20240314.15 0.792583 5584.46 8.59996e+07 14030.7 1.88908e+07 28262.2 2.30851e+07 14081 1.05021e+07 15558.6 1.25993e+07 1373.6 1.25993e+07 7217 1.67936e+07 6956.3 6.30784e+06 5777.25 1.67936e+07 97914.9 17217.6 5434.19 1.67936e+07 53209.4 56533.3 60980.9 3994.66 1.67936e+07 4357.8 21035.9 22036.6 17867.8 17344.8 43008.5 11569.9 1.02051e+06 1.15354e+06 7868.46 1402.68 834807 1.17971e+06 8.14343e+06 3.08243e+07 38033 376
82654 20240315.2 0.814514 5618.03 8.59996e+07 13992.7 1.88908e+07 28314.8 2.72794e+07 14158.4 1.05021e+07 15569.9 1.46964e+07 1370.4 1.25993e+07 6855.54 1.67936e+07 7078.3 6.30784e+06 5809.14 1.67936e+07 75376 17498.5 5471.9 1.67936e+07 53258.9 57152.3 63228.6 3964.25 1.67936e+07 4435.5 20753.7 21386.7 17614.6 17361.3 44123.6 11712.2 997407 1.10023e+06 7593.71 1401.07 835932 1.18162e+06 8.12334e+06 3.19915e+07 39409 373
82660 20240315.4 0.79239 5655.25 8.59996e+07 14026.5 1.88908e+07 28028.6 2.30851e+07 14117.6 1.05021e+07 15641.5 1.46964e+07 1368.7 1.25993e+07 6842.27 1.88908e+07 6972.1 6.30784e+06 5792.18 1.67936e+07 79337.2 17278.6 5483.28 1.67936e+07 52740.4 57193.2 62733.4 3976.83 1.67936e+07 4440.8 20988.5 22202.5 20747.1 17454.8 40414.1 11817.2 1.04406e+06 1.17137e+06 8002.43 1400.4 800286 1.18393e+06 8.15319e+06 3.06816e+07 37881 370
82675 20240315.8 0.811411 5550.01 8.59996e+07 13859.8 1.88908e+07 27849.2 2.51822e+07 13972.8 1.05021e+07 15436.6 1.46964e+07 1360.9 1.25993e+07 6846.44 1.88908e+07 6892.1 6.30784e+06 5757.2 1.67936e+07 70052.1 17268.1 5485.18 1.67936e+07 52917.8 55115.2 62057.3 3976.84 1.67936e+07 4467.7 20635 21248.1 17434.3 17246.7 45103.5 11703.8 1.0661e+06 1.1325e+06 7645.03 1395.14 835351 1.1756e+06 8.1401e+06 3.06656e+07 29503 374
82693 20240315.14 0.813428 5633.92 8.59996e+07 13977 1.67936e+07 28016.3 2.51822e+07 14070.7 1.05021e+07 15618.1 1.25993e+07 1369.8 1.25993e+07 6860.71 1.88908e+07 7091.6 6.30784e+06 5760.15 1.67936e+07 91921.9 17072.9 5477.92 1.67936e+07 52921.3 55314 60346.1 3986.61 1.67936e+07 4428.3 20651.6 17502.7 17433.9 17251.2 38435.7 11631.4 1.00654e+06 1.14155e+06 8062.66 1405.03 842520 1.17709e+06 8.14249e+06 3.25265e+07 31401 376
82711 20240315.19 0.827234 5579.84 8.59996e+07 13936.8 1.67936e+07 27473.4 2.30851e+07 14079 1.05021e+07 15445.4 1.46964e+07 1371.5 1.25993e+07 6864.43 1.88908e+07 6921.8 6.30784e+06 5786.72 1.67936e+07 78701.2 17226.4 5446.19 1.67936e+07 52920 55630.7 62135.6 3995.28 1.67936e+07 4460.1 20750.9 21671.3 17455.4 17410.8 46053.1 11590.7 1.05419e+06 1.13097e+06 7959.78 1401.86 836557 1.17881e+06 8.14735e+06 3.33301e+07 30866 378
82733 20240318.3 0.793088 5595.36 8.59996e+07 14007.8 1.67936e+07 27923.1 2.51822e+07 14120 1.05021e+07 15590.5 1.46964e+07 1375.3 1.25993e+07 6879.03 1.88908e+07 7012.8 6.30784e+06 5760.84 1.67936e+07 69387.2 17295.9 5448.96 1.67936e+07 53432.6 55698.8 61939.2 3971.05 1.67936e+07 4461.6 20831 21767.5 17645.3 17454.5 45965.6 11747.2 988142 1.1655e+06 8411.83 1399.93 811496 1.18487e+06 8.15105e+06 3.07655e+07 31024 381
82737 20240318.4 0.838162 5614.11 8.59996e+07 13974.8 1.88908e+07 27855.7 2.30851e+07 14025.9 1.05021e+07 15532.1 1.25993e+07 1369.4 1.25993e+07 7229.16 1.67936e+07 6882.1 6.30784e+06 5792.09 1.67936e+07 66151.2 17108.6 5445.12 1.67936e+07 52882.5 55297.8 61185.4 3988.23 1.67936e+07 4408.1 20714.4 21251.3 17306 17150.3 43448.6 11526.5 1.01102e+06 1.13417e+06 8227.57 1400.71 826391 1.18204e+06 8.12995e+06 3.08267e+07 32286 383
82757 20240318.11 0.814693 5551.33 8.59996e+07 13972.9 1.88908e+07 27866.3 2.30851e+07 14074.9 1.05021e+07 15512.2 1.25993e+07 1363.3 1.25993e+07 6813.84 1.88908e+07 6923.5 6.30784e+06 5738.68 1.67936e+07 90465.6 17211.7 5453.12 1.67936e+07 52996.5 55448.4 62108.6 3988.85 1.67936e+07 4458.6 20915.4 21481.4 17391 17448.8 42784.2 11560.6 1.06598e+06 1.16428e+06 8761.61 1407.29 833024 1.17982e+06 8.1325e+06 3.18334e+07 30021 357
82779 20240318.19 0.808391 5527.75 8.59996e+07 13915.1 1.67936e+07 28083.2 2.30851e+07 14015.2 1.05021e+07 15265.9 1.25993e+07 1348.1 1.25993e+07 6819.5 1.88908e+07 6934.4 6.30784e+06 5771.53 1.67936e+07 83576.3 17109.9 5438.4 1.67936e+07 52992.4 55188.2 61697.5 3990.96 1.67936e+07 4431.9 21246 21519.7 17562.4 17243.6 45272.7 11586.9 1.02912e+06 1.17744e+06 7807.78 1397.64 837965 1.1708e+06 8.13602e+06 3.07517e+07 32536 373
82788 20240318.22 0.791602 5480.12 8.59996e+07 13872.5 1.88908e+07 27842 2.30851e+07 13833.8 1.05021e+07 15367.6 1.46964e+07 1346.4 1.25993e+07 6866.93 1.88908e+07 7042 6.30784e+06 5767.17 1.67936e+07 68458.7 17216.4 5464.6 1.67936e+07 52899.6 54983.7 61392.7 3976.85 1.67936e+07 4446 20809.4 21099.7 17490.9 17107.9 42868.4 11706.2 1.04167e+06 1.1558e+06 7956.66 1403.54 835007 1.17916e+06 8.14826e+06 3.08369e+07 32882 380

service_cert_subject_name_is_configurable

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_virtual_cft^ pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_basic_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem KV ser (/s)^ KV deser (/s)^ KV snap ser (/s)^ KV snap deser (/s)^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
82707 20240315.17 28082.9 2.30851e+07 0.810747 5625.99 8.59996e+07 17248.7 85096.5 52986.9 56200 13937 1.88908e+07 62153.5 14018.9 1.05021e+07 15583.8 1.46964e+07 4433.8 20808 21851.2 17858.3 17392 1371.4 1.25993e+07 11781.5 7239.25 1.67936e+07 7086.4 6.30784e+06 5754.22 1.67936e+07 5477.04 1.88908e+07 46172.6 3968.64 1.67936e+07 991473 1.17454e+06 8110.95 1396.81 836141 1.18077e+06 8.17085e+06 3.05243e+07 32817 376
82720 20240315.22 27888.7 2.51822e+07 0.79255 5641.13 8.59996e+07 17186.6 69995.7 53118.4 55543.8 13951.8 1.88908e+07 60700.7 14007.1 1.05021e+07 15539.3 1.46964e+07 4374.1 21071 21947.2 17737.7 17269.1 1366.1 1.25993e+07 11602.8 7229.68 1.88908e+07 6918.4 6.30784e+06 5796.78 1.67936e+07 5475.74 1.67936e+07 43071.1 3990.68 1.67936e+07 1.02701e+06 1.15062e+06 8550.87 1405.19 834254 1.18187e+06 8.15628e+06 3.05289e+07 31268 375
82744 20240318.6 27885.1 2.30851e+07 0.805238 5603.33 8.59996e+07 17161.1 85514.9 52976.2 55928.1 13930.4 1.88908e+07 60954.2 13993.6 1.05021e+07 15529.3 1.46964e+07 4324.4 20670.6 21639.9 17501.7 17169.2 1377.1 1.25993e+07 11727.6 6842.78 1.88908e+07 7093.1 6.30784e+06 5789.49 1.67936e+07 5477.97 1.67936e+07 40697.8 3988.65 1.67936e+07 1.00402e+06 1.1288e+06 8139.52 1403.58 829831 1.18418e+06 8.15176e+06 3.09403e+07 31020 371
82762 20240318.12 27869.1 2.30851e+07 0.807359 5539.87 8.59996e+07 17207.8 82963.5 52913.7 55035.8 13839.7 1.88908e+07 60333.4 14009.3 1.05021e+07 15244.2 1.46964e+07 4338.1 20985.9 20871.6 17370.9 17306.9 1353.4 1.25993e+07 11658.3 6820.14 1.88908e+07 7041.1 6.30784e+06 5763.88 1.67936e+07 5444.79 1.67936e+07 46768.1 3962.98 1.67936e+07 1.03734e+06 1.16809e+06 8123.57 1397.2 833169 1.1848e+06 8.13622e+06 3.07951e+07 30043 375
82794 20240318.23 27462 2.51822e+07 0.814028 5526.46 8.59996e+07 17148.4 80669.6 52797.5 55725.2 13852 1.88908e+07 61602 13888.1 1.05021e+07 15183.3 1.46964e+07 4391.2 21127.5 21685.9 17570 17221.3 1360 1.05021e+07 11797.5 6769.45 1.88908e+07 6884.5 6.30784e+06 5787.38 1.67936e+07 5438.03 1.67936e+07 44633 3982.78 1.67936e+07 1.05119e+06 1.15088e+06 7976.21 1402.25 836458 1.18073e+06 8.16763e+06 3.07139e+07 32449 385

images

@achamayou achamayou marked this pull request as ready for review March 15, 2024 15:04
@achamayou achamayou requested a review from a team March 15, 2024 15:04
@achamayou achamayou merged commit 68d5937 into microsoft:main Mar 18, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants