-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service cert subject name is configurable #5993
Merged
achamayou
merged 20 commits into
microsoft:main
from
achamayou:service_cert_subject_name_is_configurable
Mar 18, 2024
Merged
Service cert subject name is configurable #5993
achamayou
merged 20 commits into
microsoft:main
from
achamayou:service_cert_subject_name_is_configurable
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service_cert_subject_name_is_configurable@82794 aka 20240318.23 vs main ewma over 20 builds from 82441 to 82788 Click to see tablemain
service_cert_subject_name_is_configurable
|
…ithub.com/achamayou/CCF into service_cert_subject_name_is_configurable
…ithub.com/achamayou/CCF into service_cert_subject_name_is_configurable
eddyashton
approved these changes
Mar 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuration of the service certificate subject name at network start:
Changing subject names during the lifetime of a service would impact the verification of service endorsements on historical receipts. This is because CCF sets CA & pathlen 0 on all endorsements, and while this constraint is considered met by OpenSSL when the subject_name values of historical identities match (with different public keys), it is not when they differ.
As a result, and to maintain consistent endorsement constraints, new ledgers can only set the subject_name of the service certificate once. We may revisit this in the future if necessary.