When joining, always retrieve the service's subject_name from the given cert
#6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
added
auto-backport
|
@eddyashton suggest a changelog entry |
achamayou
approved these changes
Nov 19, 2024
Good idea. I'll add that once the current runs are green, to avoid triggering/waiting for unnecessary runs. |
maxtropets
approved these changes
Nov 19, 2024
Merged
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
eddyashton
added
the
backported
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Nov 19, 2024
…iven cert (microsoft#6660) (cherry picked from commit 863681d) # Conflicts: # CHANGELOG.md # python/pyproject.toml # src/node/identity.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5993.
When 5.x nodes join from pre-5.x nodes, they end up with a default
subject_name(they get it in the join response, where it wasn't populated so had a default value). If they then try to renew the service cert, they'll cause a change in the service name. This is the minimal fix - ignore the serialisedsubject_namefield, and always extract it from the given service identity.This includes a small extension to the
lts_compatibilitytest to verify this behaviour. When run on the 5.x branch, this caused a failure without the C++ change, and passes with the C++ change.I'd like to make a more systematic cleanup of
identity.hto remove some dead code and simplify the constructor paths, but will do that separately from this minimal fix.