-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify NetworkIdentity
type
#6666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Nov 19, 2024
achamayou
reviewed
Nov 19, 2024
achamayou
approved these changes
Nov 19, 2024
achamayou
reviewed
Dec 4, 2024
achamayou
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #6660, this PR simplifies the
NetworkIdentity
type by flattening it to a single type. The core of the changes are those inidentity.h
, which removesReplicatedNetworkIdentity
and several fields fromNetworkIdentity
. This touches a bunch of other files for 2 reasons:COSESignaturesConfig
under theccf::
namespace, since it is in a public header.cose_signatures_config
fromNetworkIdentity
, the/join
endpoint innode_frontend.h
now accesses the single instance stored in/owned byhistory.h
, which takes a few hops to reach. I think some of these hops are helpful, some may be unnecessary, but regardless this fits the existing style.While we're doing this, be slightly stricter about the order of calls to history, and ensure we throw errors if
set_service_signing_identity
is called multiple times, or ifset_service_signing_identity
was not called before eitherget_cose_signatures_config
oremit_signature
.