Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable LLVM_ENABLE_TERMINFO by default. #4908

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

Keenuts
Copy link
Collaborator

@Keenuts Keenuts commented Jan 3, 2023

Having this enabled makes dxc depends on ncurses5. This is required by LLVM when supporting colored message output, but DXC doesn't supports it for now.

Fixes #4892

Having this enabled makes dxc depends on ncurses5. This is required by
LLVM when supporting colored message output, but DXC doesn't supports it
for now.

Fixes microsoft#4892
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Keenuts Keenuts merged commit 88a2888 into microsoft:main Jan 3, 2023
@Keenuts Keenuts deleted the fix-4892 branch January 3, 2023 15:59
pow2clk pushed a commit that referenced this pull request Feb 27, 2023
Having this enabled makes dxc depends on ncurses5. This is required by
LLVM when supporting colored message output, but DXC doesn't supports it
for now.

Fixes #4892

(cherry picked from commit 88a2888)
pow2clk added a commit that referenced this pull request Feb 27, 2023
Merge relevant changes into release 1.7.2212

7ce4986 Fix opt.exe external lib loading (#5049)
8f4d1f4 PIX: DxcPixDxilInstructionOffsets should operate on libs (#5046)
0795b94 Fix AppVeyor Linux tests failing loading dxil.so (#5024)
6d3574a Remove SO version from unix binaries (#5010)
6d480fd Allow libdxcompiler.so and dxc to find libdxil.so (#5004)
d751bd8 Correct WinAdapter path assumptions in public headers (#5003)
484f1b0 Fix instruction order issue in scalarizer (#5001)
d9d83d0 Fix two issues found in our internal build (#5002)
c8603e4 Added a workaround for PDBs with empty defines. (#4945)
073d860 [bug] Fix memory leak in dxil validator (#4966)
87fc5b5 PIX: Symbol manager: don't allow static members to contribute to member offsets (#4952)
8588ecb Turn off structurize-returns when cleanup blocks are present. (#4927)
bac7aa7 build: disable LLVM_ENABLE_TERMINFO by default. (#4908)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux: libdxcompiler.so dependency on libncurses5 library
3 participants