Fix two issues found in our internal build #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The StringRef in the `stringLiterals` in the `SpirvBuilder` can have a dangling reference causing undefined behaviour. 2. Two symbols can have the same name, so when we sort a vector of symbols by name, we want to use std::stable_sort to make sure we get deterministic behaviour.
pow2clk
pushed a commit
that referenced
this pull request
Feb 27, 2023
1. The StringRef in the `stringLiterals` in the `SpirvBuilder` can have a dangling reference causing undefined behaviour. 2. Two symbols can have the same name, so when we sort a vector of symbols by name, we want to use std::stable_sort to make sure we get deterministic behaviour. (cherry picked from commit 7c4927a)
pow2clk
added a commit
that referenced
this pull request
Feb 27, 2023
Merge relevant changes into release 1.7.2212 7ce4986 Fix opt.exe external lib loading (#5049) 8f4d1f4 PIX: DxcPixDxilInstructionOffsets should operate on libs (#5046) 0795b94 Fix AppVeyor Linux tests failing loading dxil.so (#5024) 6d3574a Remove SO version from unix binaries (#5010) 6d480fd Allow libdxcompiler.so and dxc to find libdxil.so (#5004) d751bd8 Correct WinAdapter path assumptions in public headers (#5003) 484f1b0 Fix instruction order issue in scalarizer (#5001) d9d83d0 Fix two issues found in our internal build (#5002) c8603e4 Added a workaround for PDBs with empty defines. (#4945) 073d860 [bug] Fix memory leak in dxil validator (#4966) 87fc5b5 PIX: Symbol manager: don't allow static members to contribute to member offsets (#4952) 8588ecb Turn off structurize-returns when cleanup blocks are present. (#4927) bac7aa7 build: disable LLVM_ENABLE_TERMINFO by default. (#4908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringLiteralsin theSpirvBuildercan have adangling reference causing undefined behaviour.
name, we want to use std::stable_sort to make sure we get deterministic
behaviour.