Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two issues found in our internal build #5002

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix two issues found in our internal build #5002

merged 1 commit into from
Feb 8, 2023

Commits on Feb 8, 2023

  1. Fix two issues found in our internal build 

    1. The StringRef in the `stringLiterals` in the `SpirvBuilder` can have a
dangling reference causing undefined behaviour.
2. Two symbols can have the same name, so when we sort a vector of symbols by
name, we want to use std::stable_sort to make sure we get deterministic
behaviour.
    @s-perron
    s-perron committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    3688c42 View commit details
    Browse the repository at this point in the history