This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Set l_rate correctly and ensure no overlap between subjects in dataset splits in CovidHierarchicalModel config #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Shruthi42
commented
May 28, 2021
Shruthi42
commented
- l_rate was set incorrectly when command line overrides were applied in CovidHierarchicalModel config.
- Remove subjects from the train and validation splits where the subject is also in the test split in the CovidHierarchicalModel config.
Shruthi42
added
the
no changelog needed
dccastro
reviewed
May 28, 2021
dccastro
reviewed
Jun 4, 2021
dccastro
approved these changes
Jun 7, 2021
melanibe
approved these changes
Jun 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.