This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Partial ground truth inference PR (465) missed two things #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2021 08:09
My approach was wrong, since it only tested the first time the mocked function was called. I've swapped to Anton's suggestion by adding return values so that the mock can be called multiple times in a test execution.
dumbledad
added
the
no changelog needed
dumbledad
removed
the
no changelog needed
dumbledad
changed the title
Shruthi42
previously approved these changes
Jul 6, 2021
ant0nsc
reviewed
Jul 6, 2021
Mocks are matched by function name string which is very fragile. If the function gets renamed this will fail prompting the renamer to fix the test.
ant0nsc
approved these changes
Jul 6, 2021
javier-alvarez
approved these changes
Jul 6, 2021
|
No linked issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two things missing/wrong in PR #465:
test_innereyecontainer_setup_passes_on_allow_incomplete_labelsonly tested the first call to the mock functionmocked_convert_channels_to_file_paths, subsequent calls in the loop were not reached.Further fixes to #459
Ensure that your PR is small, and implements one change.No, it implements two small changes.Run PyCharm's code cleanup tools on your Python files.I am using VSCode.Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.