Print warning if inference is disabled but comparison requested #537

JonathanTripp · 2021-07-13T15:34:30Z

Print warning if inference is disabled but comparison requested

dumbledad

Interesting mocks in the test. All looks good to me

Print warning if difference is disabled but comparison requested

bf38e96

JonathanTripp self-assigned this Jul 13, 2021

JonathanTripp linked an issue Jul 13, 2021 that may be closed by this pull request

Baseline comparison fails if child run inference result is not available #535

Closed

Update changelog

079c99c

JonathanTripp changed the title ~~Print warning if difference is disabled but comparison requested~~ Print warning if inference is disabled but comparison requested Jul 13, 2021

Jonathan Tripp added 13 commits July 13, 2021 16:50

It's not an f-string

0796b29

Better test of number of expected cross validation files

7a92759

Check that results exist

25e3be0

Report parent dir may not exist

3164f07

Alternate test for no reports

b1b079c

Outline report test

2549708

Fix baseline comparison test

35e8197

Add another case to baseline comparison throws

eeffc14

Test info message when infer missing

80683e2

mypy

c5c0093

Try to check report gen

d552f4c

Mock the metrics and dataset files

468eb7d

Account for uploading report

61023d4

JonathanTripp marked this pull request as ready for review July 16, 2021 09:16

Jonathan Tripp added 3 commits July 16, 2021 10:26

Merge with main

5ad4bf6

Fix merge issue

a0c1fee

Fix merge issues #2

190f0a0

JonathanTripp enabled auto-merge (squash) July 16, 2021 11:05

ant0nsc approved these changes Jul 16, 2021

View reviewed changes

dumbledad approved these changes Jul 16, 2021

View reviewed changes

JonathanTripp merged commit f6d6758 into main Jul 16, 2021

JonathanTripp deleted the jontri/ensemble_comparison branch July 16, 2021 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print warning if inference is disabled but comparison requested #537

Print warning if inference is disabled but comparison requested #537

JonathanTripp commented Jul 13, 2021 •

edited

Loading

dumbledad left a comment

Print warning if inference is disabled but comparison requested #537

Print warning if inference is disabled but comparison requested #537

Conversation

JonathanTripp commented Jul 13, 2021 • edited Loading

dumbledad left a comment

Choose a reason for hiding this comment

JonathanTripp commented Jul 13, 2021 •

edited

Loading