This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Dropping windows tests, but keeping cred-scan #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
July 15, 2021 11:14
Pull request was converted to draft
dumbledad
requested review from
javier-alvarez,
Shruthi42 and
JonathanTripp
and removed request for
JonathanTripp
ant0nsc
previously approved these changes
Jul 15, 2021
javier-alvarez
suggested changes
Jul 15, 2021
javier-alvarez
approved these changes
Jul 15, 2021
ant0nsc
approved these changes
Jul 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the Windows branch of our testing as we have been experiencing intermittent random failures in windows, which could be the result of a change in image on the test machines.
Closes #541
Please follow the guidelines for PRs contained here. Checklist:
Add unit tests for all functions that you introduced or modified.Run PyCharm's code cleanup tools on your Python files.Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.