This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix: pl_find_unused_parameters was no longer used #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melanibe
previously approved these changes
Jul 27, 2021
melanibe
previously approved these changes
Jul 27, 2021
InnerEye/ML/model_training.py
Outdated
| accelerator = "ddp" if effective_num_gpus > 1 else None | ||
| if effective_num_gpus > 1: | ||
| accelerator: Optional[str] = "ddp" | ||
| # Initialize the DDP plugin with find_unused_parameters=False by default. If True (default), it prints out |
There was a problem hiding this comment.
the comment is a bit confusing for me, the default seems to be indicated 2 times with opposite values. Does this should be interpreted as suggestion to set pl_find_unused_parameters=False in the container? if yes I would slightly change as below.
Suggested change
| # Initialize the DDP plugin with find_unused_parameters=False by default. If True (default), it prints out | |
| # Initialize the DDP plugin with find_unused_parameters=False. If True (default), it prints out |
Also, for my own understanding, where the user is setting up this default value for the container? maybe a comment there would help too?
vale-salvatelli
approved these changes
Jul 27, 2021
JonathanTripp
approved these changes
Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #531, we accidentally removed pl_find_unused_parameters. Undoing that.