Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Upgrade to Pytorch Lightning 1.5.5 #591

Merged
merged 37 commits into from
Dec 15, 2021
Merged

Upgrade to Pytorch Lightning 1.5.5 #591

merged 37 commits into from
Dec 15, 2021

Conversation

ant0nsc
Copy link
Contributor

@ant0nsc ant0nsc commented Nov 17, 2021

Most changes were triggered by changes in the metrics API

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a description of your PR,
    and if needed a motivation why that change was required.

@ant0nsc ant0nsc linked an issue Nov 17, 2021 that may be closed by this pull request
@ant0nsc
Copy link
Contributor Author

ant0nsc commented Nov 19, 2021

Putting that on hold. Upgrade leads to a 3% Dice drop on the Prostate model.

@ant0nsc ant0nsc closed this Nov 19, 2021
@ant0nsc ant0nsc reopened this Dec 13, 2021
@ant0nsc ant0nsc changed the title Upgrade to Pytorch Lightning 1.5.0 Upgrade to Pytorch Lightning 1.5.5 Dec 14, 2021
@ant0nsc
Copy link
Contributor Author

ant0nsc commented Dec 14, 2021

Comparison with present code:

Structure NewMedianDice NewMeanDice OldMedianDice OldMeanDice
external 0.996 0.994734 0.996 0.99478
femur_l 0.984 0.983982 0.984 0.983826
femur_r 0.984 0.983734 0.984 0.983633
bladder 0.972 0.966211 0.972 0.966982
rectum 0.904 0.889266 0.904 0.889633
prostate 0.866 0.853092 0.867 0.853486
seminalvesicles 0.797 0.790826 0.8 0.792367

Run on main: Prostate 5fold HD_ce452db4-5049-4393-a1ee-55d234cf2651
Run with new code: Prostate 5fold HD_1c475b3e-6923-465a-a5a2-38aacb946b87

mebristo
mebristo previously approved these changes Dec 14, 2021
Copy link
Member

@mebristo mebristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Shruthi42
Shruthi42 previously approved these changes Dec 14, 2021
InnerEye/ML/configs/classification/GlaucomaPublic.py Outdated Show resolved Hide resolved
@ant0nsc ant0nsc dismissed stale reviews from Shruthi42 and mebristo via 63eda94 December 14, 2021 17:53
@ant0nsc ant0nsc enabled auto-merge (squash) December 14, 2021 18:34
@ant0nsc ant0nsc merged commit e477c9d into main Dec 15, 2021
@ant0nsc ant0nsc deleted the antonsc/lightning15 branch December 15, 2021 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waiting for child runs to finish does not handle cancelled jobs
3 participants