Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Bug fix: SSL on multiple nodes used wrong LR scheduler #628

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

ant0nsc
Copy link
Contributor

@ant0nsc ant0nsc commented Jan 6, 2022

Closes #626

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a description of your PR,
    and if needed a motivation why that change was required.

Copy link
Contributor

@maxilse maxilse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ant0nsc ant0nsc merged commit e761af0 into main Jan 6, 2022
@ant0nsc ant0nsc deleted the antonsc/ssl_num_nodes branch January 6, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version of SimCLR is not given all required parameters
3 participants