This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
Enabling DeepSMILE on large encoded datasets #637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vale-salvatelli
changed the title
Enabling DeepSMILE on large datasets
WIP: Enabling DeepSMILE on large datasets
Jan 19, 2022
vale-salvatelli
changed the title
WIP: Enabling DeepSMILE on large datasets
Enabling DeepSMILE on large datasets
Jan 19, 2022
vale-salvatelli
changed the title
Enabling DeepSMILE on large datasets
Enabling DeepSMILE on large encoded datasets
Jan 19, 2022
ant0nsc
reviewed
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few minor comments
InnerEye/ML/configs/histo_configs/classification/DeepSMILEPanda.py
Outdated
Show resolved
Hide resolved
InnerEye/ML/configs/histo_configs/classification/DeepSMILEPanda.py
Outdated
Show resolved
Hide resolved
…a.py Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
…a.py Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
dccastro
reviewed
Jan 20, 2022
…InnerEye-DeepLearning into vsalva/chunk_encoding
ant0nsc
approved these changes
Jan 25, 2022
dccastro
approved these changes
Jan 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes necessary to run DeepSMILE on a large dataset when using the Innereye SSL checkpoint (or any other encoder with high dimension):
It also changes how the PNG images are loaded all over the histo pipeline to make the loading faster (see https://hi-ml.readthedocs.io/en/latest/loading_images.html)
Please follow the guidelines for PRs contained here. Checklist:
Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.