Code refactoring for ranking objective & Faster ndcg_xendcg #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
requested review from
chivee,
jameslamb,
Laurae2 and
StrikerRUS
as code owners
guolinke
commented
Feb 23, 2020
|
ping @sbruch for the changes in |
guolinke
force-pushed
the
fast-lambdarank
branch
from
0c9069e
to
8a9dd46
Compare
guolinke
commented
Feb 23, 2020
|
@sbruch I will merge this first. If there are any problems, feel free to open the issue/PR. |
|
@guolinke This PR removes old params related to ranking objective. Do you think it is not "breaking"? |
|
@StrikerRUS oh, I forget that change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ndcg_xendcgto O(n).ndcg_xendcg, which should not share aRandomobject in multi-threading. Furthermore, the random results should be identical now regards to different num_threads.Also some code refactorings.
Benchmark:
Boosting cost: